New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strange history behavior when history is empty #685

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
3 participants
@josephbisch
Member

josephbisch commented Apr 5, 2017

If text is being entered and then the user presses the up arrow
followed by the down arrow, the expected behavior is to return to the
text being entered. Prior to this commit that was not the case.

Fixes #462

Fix strange history behavior when history is empty
If text is being entered and then the user presses the up arrow
followed by the down arrow, the expected behavior is to return to the
text being entered. Prior to this commit that was not the case.

Fixes #462
@LemonBoy

This comment has been minimized.

Member

LemonBoy commented Apr 6, 2017

IMO we should get rid of this counted-wraparound thing and just stop when we reach the top/bottom.

@ailin-nemui ailin-nemui merged commit 3f69e71 into irssi:master Apr 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Dec 7, 2017

Merge pull request irssi#685 from josephbisch/fix-462
Fix strange history behavior when history is empty
(cherry picked from commit 3f69e71)

@ailin-nemui ailin-nemui added this to the 1.0.3 milestone Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment