New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve nicklist performance #705

Merged
merged 2 commits into from May 14, 2017

Conversation

Projects
None yet
3 participants
@ailin-nemui
Contributor

ailin-nemui commented May 12, 2017

No description provided.

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented May 12, 2017

this was mentioned by someone on IRC

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented May 12, 2017

macro or copypasta?

@LemonBoy

This comment has been minimized.

Member

LemonBoy commented May 12, 2017

Looks vile, I'd suggest writing a new iterator that walks over the hash table values descending into the lovely linked list that is the value.

@dequis

This comment has been minimized.

Member

dequis commented May 12, 2017

copypasta > macro

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented May 12, 2017

there

@dequis

dequis approved these changes May 13, 2017

@ailin-nemui ailin-nemui merged commit 476f19f into irssi:master May 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dequis

This comment has been minimized.

Member

dequis commented Jun 5, 2017

This one was originally reported as high cpu usage when receiving messages in >1000 user channels when there's an ignore that uses the "-replies" argument.

@ailin-nemui ailin-nemui deleted the ailin-nemui:nicklist-performance branch Jun 5, 2017

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Dec 7, 2017

Merge pull request irssi#705 from ailin-nemui/nicklist-performance
improve nicklist performance
(cherry picked from commit 476f19f)

@ailin-nemui ailin-nemui added this to the 1.0.3 milestone Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment