New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not reset true colour bit on colour reset #711

Merged
merged 1 commit into from May 30, 2017

Conversation

Projects
None yet
1 participant
@ailin-nemui
Contributor

ailin-nemui commented May 26, 2017

fixes #710

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented May 26, 2017

I think this is the right thing to do because we want to keep the flags, so in case of a partial reset (background reset, or foreground reset, or the terminfo parser returning to normal mode) at the same time of a 24bit colour code, Irssi would otherwise forget from which register to restore the colour (base colours or 24bit) and always pick the base one.

I just hope I'm not overlooking something but it was probably simply a bug in my original implementation

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented May 26, 2017

(it works when a space is added because then Irssi will send %n%o<space>%ZB58900 instead of %ZB58900%o)

@ailin-nemui ailin-nemui merged commit 2d0a9b4 into irssi:master May 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui deleted the ailin-nemui:24bit-reset branch Aug 17, 2017

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Dec 7, 2017

Merge pull request irssi#711 from ailin-nemui/24bit-reset
do not reset true colour bit on colour reset
(cherry picked from commit 2d0a9b4)

@ailin-nemui ailin-nemui added this to the 1.0.3 milestone Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment