New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

term-terminfo: Avoid switching out of alt screen on unexpected exits #721

Merged
merged 1 commit into from Jun 23, 2017

Conversation

Projects
None yet
2 participants
@dequis
Member

dequis commented Jun 17, 2017

Perl sucks and kills the whole process when there's a version mismatch
in Perl_xs_handshake(). Our atexit handler catches the exit and
deinitializes the terminal, removing the error.

This commit uses the 'quitting' global variable which is set when irssi
is voluntarily quitting, and avoids sending TI_rmcup, which restores the
original screen and makes the error invisible.


Fixes #287

Check that beauty:

screenshot

term-terminfo: Avoid switching out of alt screen on unexpected exits
Perl sucks and kills the whole process when there's a version mismatch
in Perl_xs_handshake(). Our atexit handler catches the exit and
deinitializes the terminal, removing the error.

This commit uses the 'quitting' global variable which is set when irssi
is voluntarily quitting, and avoids sending TI_rmcup, which restores the
original screen and makes the error invisible.
@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Jun 17, 2017

but it will leave you stuck in full screen mode which is also not nice

@dequis

This comment has been minimized.

Member

dequis commented Jun 17, 2017

The shell works decently enough and all the other terminfo things are reset. I've seen worse broken states. I think it's a decent tradeoff considering it pretty much just crashed.

@ailin-nemui ailin-nemui merged commit c569197 into irssi:master Jun 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Dec 7, 2017

Merge pull request irssi#721 from dequis/unexpected-exits
term-terminfo: Avoid switching out of alt screen on unexpected exits
(cherry picked from commit c569197)

@ailin-nemui ailin-nemui added this to the 1.0.4 milestone Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment