New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compute log_dir_create_mode in three different places. #734

Merged
merged 5 commits into from Jul 30, 2017

Conversation

Projects
None yet
4 participants
@trasz
Contributor

trasz commented Jul 28, 2017

Signed-off-by: Edward Tomasz Napierala trasz@FreeBSD.org

trasz added some commits Jul 28, 2017

Don't compute log_dir_create_mode in three different places.
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
Add missing diagnostics for rawlog open().
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
@dequis

This comment has been minimized.

Member

dequis commented Jul 29, 2017

I guess that's ok. Not sure what motivated this.

@@ -130,6 +130,7 @@ void rawlog_open(RAWLOG_REC *rawlog, const char *fname)
log_file_create_mode);
if (rawlog->handle == -1) {
g_warning("rawlog open() failed: %s", strerror(errno));
return;

This comment has been minimized.

@LemonBoy

LemonBoy Jul 29, 2017

Member

You leak path, move the g_free before the if

This comment has been minimized.

@trasz

trasz Jul 29, 2017

Contributor

You're right, thanks! (That's what happens when you try to fix things before the morning coffee...)

trasz added some commits Jul 29, 2017

When rawlog open fails, there's no point in trying to write. Don't.
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
Consistency: use FALSE instead of 0.
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
Fix vertical alignment in ./configure --help output.
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>

@LemonBoy LemonBoy merged commit 663a8e7 into irssi:master Jul 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment