New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment the X509_STORE refcount during the connection #751

Merged
merged 2 commits into from Sep 13, 2017

Conversation

Projects
None yet
2 participants
@LemonBoy
Member

LemonBoy commented Sep 11, 2017

OpenSSL doesn't increment the reference count when the store is assigned
to a SSL_CTX.

Fixes #750

LemonBoy added some commits Sep 11, 2017

Increment the X509_STORE refcount during the connection
OpenSSL doesn't increment the reference count when the store is assigned
to a SSL_CTX.
Restore compatibility with old OpenSSL versions
Let's implement X509_STORE_up_ref on our own.
@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Sep 12, 2017

nice, lgtm. should we go for the simpler:

#define X509_STORE_up_ref(store) CRYPTO_add(&(store)->references, 1, CRYPTO_LOCK_X509_STORE)

https://fossies.org/linux/h2o/include/h2o/openssl_backport.h

instead?

@ailin-nemui ailin-nemui merged commit ca1172b into irssi:master Sep 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dequis dequis referenced this pull request Jan 20, 2018

Closed

crash in x509 #820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment