New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to statusbar documentation and help text. #763

Merged
merged 5 commits into from Oct 8, 2017

Conversation

Projects
None yet
3 participants
@rbisewski
Contributor

rbisewski commented Oct 6, 2017

As per issue #758, I have made an attempt at improving both the HOWTO and the "/help statusbar" content to better reflect the current state of irssi statusbar functionality.

@dequis

This comment has been minimized.

Member

dequis commented Oct 6, 2017

Thanks!

Looks like we totally forgot there was a copy of the startup doc in this repo. It's outdated relative to the one in https://github.com/irssi/irssi.github.io/blob/master/documentation/startup/index.markdown

Can you drop that part of this PR and send those changes to the other repo? We'll just use pandoc or something to generate a whole new startup-HOWTO.html

Haven't reviewed too much for correctness but sounds about right. Nitpicks on wording: I'd use "number" over "unsigned integer", and maybe change those "refers to" to "sets" (assuming all of them are commands to set attributes of the statusbar, right?)

I'm not sure disable completely removes the statusbar every time. I think that's just the non-builtin ones.

@rbisewski

This comment has been minimized.

Contributor

rbisewski commented Oct 6, 2017

I have since made the requested changes to the pull-request from your above feedback, and have created a fork of your site and added the HOWTO changes into it.

Let me know if you notice anything else.

@ailin-nemui ailin-nemui merged commit 016fd34 into irssi:master Oct 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Oct 8, 2017

thanks

@ailin-nemui ailin-nemui referenced this pull request Oct 8, 2017

Closed

sync docs <-> website #765

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Dec 7, 2017

Merge pull request irssi#763 from rbisewski/master
Improvements to statusbar documentation and help text.

@ailin-nemui ailin-nemui added this to the 1.0.5 milestone Jan 10, 2018

lkundrak pushed a commit to lkundrak/irssi that referenced this pull request Feb 16, 2018

Merge pull request irssi#763 from rbisewski/master
Improvements to statusbar documentation and help text.

(cherry picked from commit 016fd34)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment