New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a couple unused functions #770

Merged
merged 5 commits into from Oct 23, 2017

Conversation

Projects
None yet
4 participants
@horgh
Member

horgh commented Oct 9, 2017

I noticed an unused function and then saw another. I see one was already marked deprecated, so maybe there's a reason we should keep it, but anyway.

@LemonBoy

This comment has been minimized.

Member

LemonBoy commented Oct 10, 2017

You should deprecate first, then remove, but not in a minor release.

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Oct 10, 2017

I think we can accept this into master..

@dequis

This comment has been minimized.

Member

dequis commented Oct 11, 2017

-1, it's public api, modules exist, deprecate first.

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Oct 11, 2017

let's remove the deprecated one, the ip compare I don't really care.. could be useful but I don't see it used anywhere

@dequis

This comment has been minimized.

Member

dequis commented Oct 11, 2017

Oh right one of them is deprecated already. Looks like that was part of #422 included in 1.0.0. I'm ok with removing that.

net_ip_compare is small, doesn't hurt. But yeah, useless. Looks like timo sirainen copypasting his own code from dovecot.

@horgh

This comment has been minimized.

Member

horgh commented Oct 14, 2017

I reverted removing the one that wasn't already marked deprecated, and marked it deprecated.

@ailin-nemui ailin-nemui merged commit cfa51c5 into irssi:master Oct 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment