Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show initial nick and name on first start #786

Merged
merged 3 commits into from Nov 15, 2017

Conversation

Projects
None yet
5 participants
@ailin-nemui
Copy link
Contributor

commented Nov 1, 2017

fixes #785

ailin-nemui added some commits Nov 1, 2017

@@ -223,6 +223,7 @@ static void textui_deinit(void)
#endif

dirty_check(); /* one last time to print any quit messages */

This comment has been minimized.

Copy link
@vague666

vague666 Nov 1, 2017

Member

looks like a space here

This comment has been minimized.

Copy link
@ailin-nemui

ailin-nemui Nov 1, 2017

Author Contributor

I didn't touch the line

This comment has been minimized.

Copy link
@vague666

vague666 Nov 1, 2017

Member

But you were on the adjacent line, uparrow once and delete the spaces :P

This comment has been minimized.

Copy link
@LemonBoy

LemonBoy Nov 2, 2017

Member

We're going to run clang-format over the whole codebase anyway, don't worry about the stylistic details :)

@@ -249,6 +250,7 @@ static void textui_deinit(void)
core_deinit();
}


This comment has been minimized.

Copy link
@vague666

vague666 Nov 1, 2017

Member

2 empty lines here

fe_settings_set_print("user_name");
if (user_settings_changed & (1<<2))
fe_settings_set_print("nick");
if (user_settings_changed & (1<<3))

This comment has been minimized.

Copy link
@dequis

dequis Nov 1, 2017

Member

Enum?

@dequis

This comment has been minimized.

Copy link
Member

commented Nov 1, 2017

I really like this idea, also the part of moving banners to formats

@@ -39,6 +39,7 @@ static GString *last_errors;
static GSList *last_invalid_modules;
static int fe_initialized;
static int config_changed; /* FIXME: remove after .98 (unless needed again) */
static int user_settings_changed;

This comment has been minimized.

Copy link
@LemonBoy

LemonBoy Nov 2, 2017

Member

int -> unsigned if you're going to use it as a bitmap



static void sig_exit(void)
{
quitting = TRUE;
}

static void sig_settings_userinfo_changed(gpointer changedp)
{
user_settings_changed = GPOINTER_TO_INT(changedp);

This comment has been minimized.

Copy link
@LemonBoy

LemonBoy Nov 2, 2017

Member

Changing = to |= makes this mechanism more flexible in case we ever need to print other welcome warnings from outside init_userinfo.

@@ -116,14 +116,17 @@ static void sig_server_setup_fill_chatnet(IRC_SERVER_CONNECT_REC *conn,

static void init_userinfo(void)
{
int changed;

This comment has been minimized.

Copy link
@LemonBoy

LemonBoy Nov 2, 2017

Member

Ditto

@@ -223,6 +223,7 @@ static void textui_deinit(void)
#endif

dirty_check(); /* one last time to print any quit messages */

This comment has been minimized.

Copy link
@LemonBoy

LemonBoy Nov 2, 2017

Member

We're going to run clang-format over the whole codebase anyway, don't worry about the stylistic details :)

static int display_firsttimer = FALSE;
static int user_settings_changed = 0;

This comment has been minimized.

Copy link
@LemonBoy

LemonBoy Nov 2, 2017

Member

Ditto.

@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented Nov 10, 2017

thanks for all reviews

@ailin-nemui ailin-nemui merged commit 4e8c154 into irssi:master Nov 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui deleted the ailin-nemui:show-inital-nick branch Nov 15, 2017

@tomasi-o

This comment has been minimized.

Copy link

commented Oct 23, 2018

Is this already fixed in irssi 1.1.1 (20180213 1256)?

@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2018

yes this is in Irssi 1.1.0 and later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.