New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep a copy of the strings coming from the config #788

Merged
merged 1 commit into from Nov 14, 2017

Conversation

Projects
None yet
3 participants
@LemonBoy
Member

LemonBoy commented Nov 3, 2017

Fixes #787, checked with valgrind.

Keep a copy of the strings coming from the config
The "HILIGHT_REC" structure used to keep a pointer to the "servertag"
string, owned by the "CONFIG_NODE", causing a double-free.
@dequis

This comment has been minimized.

Member

dequis commented Nov 9, 2017

The commit message made this sound like a much bigger thing

@ailin-nemui ailin-nemui merged commit 933fac7 into irssi:master Nov 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui added this to the 1.0.6 milestone Jan 10, 2018

lkundrak pushed a commit to lkundrak/irssi that referenced this pull request Feb 16, 2018

Merge pull request irssi#788 from LemonBoy/fix-787
Keep a copy of the strings coming from the config

(cherry picked from commit 933fac7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment