Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset colour at comma, like mIRC #790

Merged
merged 2 commits into from Nov 26, 2017

Conversation

Projects
None yet
2 participants
@ailin-nemui
Copy link
Contributor

commented Nov 15, 2017

Fixes #742 and fixes #740

@LemonBoy
Copy link
Member

left a comment

Looks safe to me, I've only left a comment about a minor adjustment.

@@ -1072,7 +1072,8 @@ static void get_mirc_color(const char **str, int *fg_ret, int *bg_ret)
fg = fg_ret == NULL ? -1 : *fg_ret;
bg = bg_ret == NULL ? -1 : *bg_ret;

if (!i_isdigit(**str) && **str != ',') {
if (!i_isdigit(**str)) {
/* turn off color */
fg = -1;
bg = -1;
} else {

This comment has been minimized.

Copy link
@LemonBoy

LemonBoy Nov 20, 2017

Member

The if (**str != ',') { check below can be removed because now **str is a digit.

Update formats.c
remove now useless check for ,
@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented Nov 20, 2017

thanks for review, removed that check

@ailin-nemui ailin-nemui merged commit 5637a8d into irssi:master Nov 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui deleted the ailin-nemui:mirc-colour branch Nov 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.