New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for declaration-after-statement on travis #795

Merged
merged 3 commits into from Nov 30, 2017

Conversation

Projects
None yet
2 participants
@ailin-nemui
Contributor

ailin-nemui commented Nov 29, 2017

this will make variable declarations after statements illegal. most of the code follows this practice. in the past, this was required to be able to compile on BeOS iirc

@@ -295,6 +295,9 @@ fi
LIBS="$LIBS $GLIB_LIBS"
GLIB_CFLAGS=" $GLIB_CFLAGS"
GLIB_CFLAGS="${GLIB_CFLAGS// -I/ -isystem}"

This comment has been minimized.

@dequis

This comment has been minimized.

@ailin-nemui

ailin-nemui Nov 29, 2017

Contributor

.... I don't think I intended to commit that.... If you're curious, it is a useful feature, if you want to compile your own code with -pedantic or more warnings, since -isystem will hide warnings in those directories ( as opposed to -I )

@dequis

dequis approved these changes Nov 30, 2017

@ailin-nemui ailin-nemui merged commit 02aa8ee into irssi:master Nov 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui deleted the ailin-nemui:no-mixed-decl branch Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment