Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle an already used nick different from the one we send #804

Merged
merged 2 commits into from Jan 7, 2018

Conversation

Projects
None yet
2 participants
@ailin-nemui
Copy link
Contributor

commented Jan 4, 2018

continuation of fixes #219
I think this should work

Alexandre Morignot and others added some commits Feb 10, 2015

Update irc-nicklist.c
move altnick check before the nick correction code
@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented Jan 6, 2018

@dequis

dequis approved these changes Jan 7, 2018

Copy link
Member

left a comment

This one has been in the queue for waaaaaaaaaay too long, so long that the parent commits are full of compilation warnings that I haven't seen in a long while. Merges fine and works as intended.

nit: those Update <filename> commit messages are terrible, the subject is meaningless and the actual commit message in the body, please avoid doing that in the future (doesn't need to be changed this time).


g_return_if_fail(data != NULL);

if (server->connected) {
/* Already connected, no need to handle this anymore. */
return;
}

This comment has been minimized.

Copy link
@dequis

dequis Jan 7, 2018

Member

nit: whitespace

@ailin-nemui ailin-nemui merged commit e7cce90 into irssi:master Jan 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui deleted the ailin-nemui:patch-1 branch Jan 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.