Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
try to make sure the server is still good enough to call ischannel when printing netsplit/join #832
referenced this pull request
Jan 25, 2018
Continuing #819 (comment) here:
This throws two warnings:
It also seems to not flush pending netsplits like lemon-netsplit-base does
So the safer one for 1.1.1, and this one for git? Sounds like a plan.
There's still the issue that this won't flush pending netsplits when quitting, but that's not a big deal. The real question is if the circumstances that lead to netsplits not being flushed on quit (non-null server, null target) can apply to other less situations in the middle of the connection.