Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcc get shouldn't fail when file attrs can't be changed #844

merged 1 commit into from Feb 13, 2018


Copy link

CatboxParadox commented Feb 12, 2018

Running irssi from within Termux on an un-rooted NVIDIA Shield TV.

DCC downloads never worked for me, no matter what target directory I'd choose... Would you be willing to accept this PR? I don't think the DCC download should fail just because the desired file attributes can't be set (according to strace fchmod fails with EPERM).

Also extending the hardlink workaround to EACCES, not just EPERM (happens when my target directory is an external drive w/ NTFS).

@@ -247,7 +250,7 @@ void sig_dccget_connected(GET_DCC_REC *dcc)

if (ret == -1 &&
/* Linux */
(errno == EPERM ||
(errno == EPERM || errno == EACCES ||

This comment has been minimized.


dequis Feb 12, 2018 Member

This probably belongs below /* FUSE */ if it happens with ntfs-3g

Copy link

ailin-nemui commented Feb 12, 2018

maybe it would be good to print a warning if chmod fails?

@CatboxParadox CatboxParadox force-pushed the CatboxParadox:perms branch from 39ec9e1 to 3cbcb4f Feb 13, 2018
Copy link
Contributor Author

CatboxParadox commented Feb 13, 2018

Moved the EACESS errno check to the /* FUSE */ section; warning added.

Copy link

ailin-nemui commented Feb 13, 2018

looks ok to me..

dequis approved these changes Feb 13, 2018
@ailin-nemui ailin-nemui merged commit c01f6df into irssi:master Feb 13, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
@CatboxParadox CatboxParadox deleted the CatboxParadox:perms branch Feb 13, 2018
@ailin-nemui ailin-nemui added this to the 1.2.0 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.