New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcc get shouldn't fail when file attrs can't be changed #844

Merged
merged 1 commit into from Feb 13, 2018

Conversation

Projects
None yet
3 participants
@CatboxParadox
Contributor

CatboxParadox commented Feb 12, 2018

Running irssi from within Termux on an un-rooted NVIDIA Shield TV.

DCC downloads never worked for me, no matter what target directory I'd choose... Would you be willing to accept this PR? I don't think the DCC download should fail just because the desired file attributes can't be set (according to strace fchmod fails with EPERM).

Also extending the hardlink workaround to EACCES, not just EPERM (happens when my target directory is an external drive w/ NTFS).

@ailin-nemui

This comment has been minimized.

Show comment
Hide comment
@ailin-nemui

ailin-nemui Feb 12, 2018

Contributor

maybe it would be good to print a warning if chmod fails?

Contributor

ailin-nemui commented Feb 12, 2018

maybe it would be good to print a warning if chmod fails?

@CatboxParadox

This comment has been minimized.

Show comment
Hide comment
@CatboxParadox

CatboxParadox Feb 13, 2018

Contributor

Moved the EACESS errno check to the /* FUSE */ section; warning added.

Contributor

CatboxParadox commented Feb 13, 2018

Moved the EACESS errno check to the /* FUSE */ section; warning added.

@ailin-nemui

This comment has been minimized.

Show comment
Hide comment
@ailin-nemui

ailin-nemui Feb 13, 2018

Contributor

looks ok to me..

Contributor

ailin-nemui commented Feb 13, 2018

looks ok to me..

@dequis

dequis approved these changes Feb 13, 2018

@ailin-nemui ailin-nemui merged commit c01f6df into irssi:master Feb 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@CatboxParadox CatboxParadox deleted the CatboxParadox:perms branch Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment