New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make default keybinds deletable #859

Merged
merged 2 commits into from Mar 19, 2018

Conversation

Projects
None yet
2 participants
@ailin-nemui
Copy link
Contributor

ailin-nemui commented Mar 12, 2018

this should fix #507

@ailin-nemui ailin-nemui force-pushed the ailin-nemui:delkeys branch 2 times, most recently from e687ad0 to 4f34399 Mar 12, 2018

@ailin-nemui ailin-nemui force-pushed the ailin-nemui:delkeys branch from 4f34399 to 7ec6c50 Mar 12, 2018

@ailin-nemui

This comment has been minimized.

Copy link
Contributor

ailin-nemui commented Mar 12, 2018

@peterleurs if you want you can test it :)

@ailin-nemui

This comment has been minimized.

Copy link
Contributor

ailin-nemui commented Mar 15, 2018

@dequis

This comment has been minimized.

Copy link
Member

dequis commented Mar 15, 2018

Hm, this changed a bit since i looked at it, what's new, the -reset thing?

@ailin-nemui

This comment has been minimized.

Copy link
Contributor

ailin-nemui commented Mar 15, 2018

I thought it might be useful to reset something to the default config (before, deleting would mean it was reset to default state after restart)

@dequis

This comment has been minimized.

Copy link
Member

dequis commented Mar 19, 2018

Tested, looks good, docs/help/in/bind.in needs a mention of -reset

@ailin-nemui

This comment has been minimized.

Copy link
Contributor

ailin-nemui commented Mar 19, 2018

thanks for review

@dequis

dequis approved these changes Mar 19, 2018

@ailin-nemui ailin-nemui merged commit 6ffbd0a into irssi:master Mar 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui deleted the ailin-nemui:delkeys branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment