Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make default keybinds deletable #859

Merged
merged 2 commits into from Mar 19, 2018
Merged

make default keybinds deletable #859

merged 2 commits into from Mar 19, 2018

Conversation

@ailin-nemui
Copy link
Contributor

@ailin-nemui ailin-nemui commented Mar 12, 2018

this should fix #507

@ailin-nemui ailin-nemui force-pushed the ailin-nemui:delkeys branch 2 times, most recently from e687ad0 to 4f34399 Mar 12, 2018
@ailin-nemui ailin-nemui force-pushed the ailin-nemui:delkeys branch from 4f34399 to 7ec6c50 Mar 12, 2018
@ailin-nemui
Copy link
Contributor Author

@ailin-nemui ailin-nemui commented Mar 12, 2018

@peterleurs if you want you can test it :)

@ailin-nemui
Copy link
Contributor Author

@ailin-nemui ailin-nemui commented Mar 15, 2018

@dequis
Copy link
Member

@dequis dequis commented Mar 15, 2018

Hm, this changed a bit since i looked at it, what's new, the -reset thing?

@ailin-nemui
Copy link
Contributor Author

@ailin-nemui ailin-nemui commented Mar 15, 2018

I thought it might be useful to reset something to the default config (before, deleting would mean it was reset to default state after restart)

@dequis
Copy link
Member

@dequis dequis commented Mar 19, 2018

Tested, looks good, docs/help/in/bind.in needs a mention of -reset

@ailin-nemui
Copy link
Contributor Author

@ailin-nemui ailin-nemui commented Mar 19, 2018

thanks for review

@dequis
dequis approved these changes Mar 19, 2018
@ailin-nemui ailin-nemui merged commit 6ffbd0a into irssi:master Mar 19, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ailin-nemui ailin-nemui deleted the ailin-nemui:delkeys branch Mar 29, 2018
@ailin-nemui ailin-nemui added this to the 1.2.0 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants