Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconnect lookup_servers also #866

Merged
merged 1 commit into from Apr 6, 2018
Merged

Conversation

@ailin-nemui
Copy link
Contributor

@ailin-nemui ailin-nemui commented Mar 29, 2018

This is a simple change which might fix #130

The lookup_servers are also disconnected if the lookup/SSL handshake doesn't succeed in time. I'm not perfectly sure if this is the master fix but it does seem to be an issue that servers can be stuck in lookup

@ailin-nemui
Copy link
Contributor Author

@ailin-nemui ailin-nemui commented Apr 2, 2018

@LemonBoy
Copy link
Member

@LemonBoy LemonBoy commented Apr 3, 2018

LGTM, the error message could be slightly more informative than just "Timeout" but I'm just nitpicking.
The commit message, on the other hand, is horrendous since it doesn't explain what it fixes nor how it works nor it links the related ticket.

@ailin-nemui
Copy link
Contributor Author

@ailin-nemui ailin-nemui commented Apr 4, 2018

Thanks for Review

@ailin-nemui ailin-nemui merged commit b2b1ac6 into irssi:master Apr 6, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ailin-nemui ailin-nemui deleted the ailin-nemui:reconnects branch Apr 6, 2018
@ailin-nemui ailin-nemui added this to the 1.2.0 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants