New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly separate ignore flags (no_act, hidden) from level #937

Merged
merged 4 commits into from Sep 23, 2018

Conversation

Projects
None yet
3 participants
@ailin-nemui
Copy link
Contributor

ailin-nemui commented Sep 17, 2018

another attempt at fix #900

@dwfreed
Copy link
Member

dwfreed left a comment

:shipit:

level &= ~FLAG_MSGLEVELS;
flags &= FLAG_MSGLEVELS;

return ((FLAG_MSGLEVELS & rec->level) == flags) && ((level & rec->level) != 0);

This comment has been minimized.

@ailin-nemui

ailin-nemui Sep 17, 2018

Contributor

need to fix this. no_act hidden ??

This comment has been minimized.

@dwfreed

dwfreed Sep 17, 2018

Member

Revert 011d943 and that'll fix that.

@dwfreed

This comment has been minimized.

Copy link
Member

dwfreed commented Sep 20, 2018

@dequis can you test that this fixes your issue?

@ailin-nemui

This comment has been minimized.

Copy link
Contributor

ailin-nemui commented Sep 20, 2018

@dwfreed reverting it as you commented didn't fix it, but reverting to your original code did

@dequis

This comment has been minimized.

Copy link
Member

dequis commented Sep 21, 2018

Can't really test much these days, no

@ailin-nemui ailin-nemui merged commit 5785785 into irssi:master Sep 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui deleted the ailin-nemui:hidden-ignores branch Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment