Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route notices intended for channels into the channel #959

Merged
merged 3 commits into from Oct 8, 2018

Conversation

@ailin-nemui
Copy link
Contributor

@ailin-nemui ailin-nemui commented Oct 5, 2018

This works for

-ChanServ(ChanServ@services.)- [#irssi] Welcome to #irssi.

or

-bI(~xxx@unaffiliated/account)- [#irssi] your message is restrained

etc.

@dequis
Copy link
Member

@dequis dequis commented Oct 5, 2018

Fancy! I kinda wanted this behavior too.

Might be worth moving the check from [ to the strndup to a separate function that returns either string or null?

@ailin-nemui
Copy link
Contributor Author

@ailin-nemui ailin-nemui commented Oct 5, 2018

good idea

@ailin-nemui
Copy link
Contributor Author

@ailin-nemui ailin-nemui commented Oct 6, 2018

Copy link
Member

@dwfreed dwfreed left a comment

I like the idea, but at the same time I'd prefer it were optional (you can make it default on, I just want to be able to turn it off)

@ailin-nemui
Copy link
Contributor Author

@ailin-nemui ailin-nemui commented Oct 7, 2018

always good to have options, but why would you like it off?

@dwfreed
Copy link
Member

@dwfreed dwfreed commented Oct 7, 2018

  1. In my case, I have a permanent query window with ChanServ (and other services), intentionally so that all ChanServ messages go there; this bypasses that
  2. As an oper, I don't want random users to be able to flood the channel window of their choice just by forming their message in a special way
@dequis
Copy link
Member

@dequis dequis commented Oct 7, 2018

+1 for the setting, I thought about it but failed to come up with use cases where it's undesirable.

Regarding the latter, that's probably worth thinking about a bit more, maybe check what restrictions are set by other clients that implement this behavior. Channel membership of the source nick?

@ailin-nemui
Copy link
Contributor Author

@ailin-nemui ailin-nemui commented Oct 7, 2018

we talked about it on IRC but ChanServ, a prime offender, is often not on channel

@ailin-nemui
Copy link
Contributor Author

@ailin-nemui ailin-nemui commented Oct 8, 2018

@dwfreed
dwfreed approved these changes Oct 8, 2018
@ailin-nemui ailin-nemui merged commit 4eff3f1 into irssi:master Oct 8, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ailin-nemui ailin-nemui deleted the ailin-nemui:notice-routing branch Oct 8, 2018
@ailin-nemui ailin-nemui added this to the 1.2.0 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants