Skip to content

Fix MC-88371 crash #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix MC-88371 crash #379

merged 1 commit into from
Jan 15, 2025

Conversation

rvbsm
Copy link
Contributor

@rvbsm rvbsm commented Dec 21, 2024

Starting from 1.21.2 (24w39a) DragonLandingPhase#doServerTick uses ServerLevel. Fixes #376

DragonLandingPhase#doServerTick

  @Override
- public void doServerTick() {
+ public void doServerTick(ServerLevel serverLevel) {
      if (this.targetLocation == null) {
          this.targetLocation = Vec3.atBottomCenterOf(
-             this.dragon.level().getHeightmapPos(Heightmap.Types.MOTION_BLOCKING_NO_LEAVES, EndPodiumFeature.getLocation(this.dragon.getFightOrigin()))
+             serverLevel.getHeightmapPos(Heightmap.Types.MOTION_BLOCKING_NO_LEAVES, EndPodiumFeature.getLocation(this.dragon.getFightOrigin()))
          );
      }
    ...
  }

@Riflusso
Copy link

@isXander can you merge it, please? 🥺 Or implement it by yourself🙏

@isXander isXander merged commit 5892fc8 into isXander:1.21.3 Jan 15, 2025
isXander pushed a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Crashing when entering end dimension
3 participants