Optimizes Kit XR Teleop CPU time #3487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With kitxr 107.3.111, we can save cpu time by skipping writes to usd stage since all the data is in fabric. On the tested workstation, it saved 11ms on the main thread. Additionally, texture streaming was bottlenecking the render thread. Disabling resulted in 11ms savings on the renderthread. Together, it resulted in 11ms on the tested workstation as those two bottlenecked each other.
hougantc-nvda
requested review from
Mayankm96,
Toni-SM,
hhansen-bdai,
jtigue-bdai,
kellyguo11,
ooctipus and
pascal-roth
as code owners
github-actions
bot
added
documentation
hougantc-nvda
changed the title
kellyguo11
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With kitxr 107.3.111, we can save cpu time by skipping writes to usd stage since all the data is in fabric. This gives us back 11ms (on my machine) on the main thread. Additionally, texture streaming was bottlenecking the render thread. Disabling gave us back 11ms on the renderthread. Together, it gave me back 11ms.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there