Skip to content

Fix quadruped tutorial noise import#6032

Closed
ooctipus wants to merge 1 commit into
isaac-sim:release/3.0.0-beta2from
ooctipus:fix/beta2-quadruped-noise-import
Closed

Fix quadruped tutorial noise import#6032
ooctipus wants to merge 1 commit into
isaac-sim:release/3.0.0-beta2from
ooctipus:fix/beta2-quadruped-noise-import

Conversation

@ooctipus

@ooctipus ooctipus commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Update the quadruped base tutorial to import UniformNoiseCfg, which is the beta2 noise config API used elsewhere in the repo.
  • Preserve behavior: UniformNoiseCfg defaults to additive noise, matching the tutorial usage.

Validation

  • python3 -m py_compile scripts/tutorials/03_envs/create_quadruped_base_env.py
  • python3 tools/changelog/cli.py check release/3.0.0-beta2
  • pre-commit run --files scripts/tutorials/03_envs/create_quadruped_base_env.py

Full Kit launch was not run locally; this environment does not have the prepared Isaac Lab runtime dependencies installed.

@github-actions github-actions Bot added bug Something isn't working isaac-lab Related to Isaac Lab team labels Jun 8, 2026
@greptile-apps

greptile-apps Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a broken import in the quadruped base tutorial script. AdditiveUniformNoiseCfg does not exist anywhere in the isaaclab.utils.noise module (confirmed by codebase search), so the previous import would raise an ImportError at startup. The replacement UniformNoiseCfg is the correct beta2 API and defaults to operation="add", matching the additive noise intent of all six Unoise(...) usages in the file.

  • Replaces AdditiveUniformNoiseCfg (non-existent) with UniformNoiseCfg (defined in noise_cfg.py) in the single changed file.
  • No logic, behavior, or API surface changes — alias Unoise and all call sites remain identical.

Confidence Score: 5/5

Safe to merge — the change corrects a broken import that would prevent the tutorial from running at all, replacing it with the correct class that provides identical additive noise behavior.

The old import AdditiveUniformNoiseCfg does not exist in the codebase, meaning the tutorial would immediately crash with an ImportError on any invocation. The fix uses UniformNoiseCfg, which is the correct class, is fully exported from the noise module, and defaults to the same additive operation. All six call sites in the file are unaffected. This is a single-line, targeted fix with no side effects.

No files require special attention.

Important Files Changed

Filename Overview
scripts/tutorials/03_envs/create_quadruped_base_env.py Fixes a broken import by replacing non-existent AdditiveUniformNoiseCfg with UniformNoiseCfg, which exists in the noise module and defaults to additive operation — preserving the tutorial's intended behavior.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["tutorial script startup"] --> B["import UniformNoiseCfg as Unoise\n(isaaclab.utils.noise)"]
    B --> C["UniformNoiseCfg\noperation = 'add' (default)"]
    C --> D["ObservationsCfg:\nUnoise used for 6 ObsTerm noise fields"]
    D --> E["Additive noise applied\nto observations at runtime"]

    subgraph "Before (broken)"
        F["import AdditiveUniformNoiseCfg\n→ ImportError (class does not exist)"]
    end

    subgraph "After (fixed)"
        G["import UniformNoiseCfg\n→ same additive behavior, correct API"]
    end
Loading

Reviews (1): Last reviewed commit: "Fix quadruped tutorial noise import" | Re-trigger Greptile

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Isaac Lab Review Bot — PR #6032

Summary

Single-line import fix in the quadruped base tutorial: replaces the removed AdditiveUniformNoiseCfg with the beta2-era UniformNoiseCfg.

Findings

# Severity Category Detail
1 Correctness UniformNoiseCfg exists in isaaclab.utils.noise on release/3.0.0-beta2 (confirmed in __init__.pyi and noise_cfg.py). AdditiveUniformNoiseCfg is not exported from the beta2 noise module, so the old import would raise ImportError at runtime.
2 Behavior preservation UniformNoiseCfg inherits from NoiseCfg which defaults operation = "add". All usages in this file (Unoise(n_min=..., n_max=...)) rely on additive noise — behavior is preserved exactly.
3 API consistency Other task/test configs on this branch (e.g., check_manager_based_env_anymal_locomotion.py) already use UniformNoiseCfg. This aligns the tutorial with the rest of the codebase.
4 ℹ️ Scope note ~14 other files in the repo still reference AdditiveUniformNoiseCfg (mostly in isaaclab_tasks). These likely need similar fixes but are reasonably out of scope for this targeted tutorial fix. Consider a follow-up sweep.
5 ℹ️ CI status pre-commit ✅, Build Wheel ✅, changelog check ✅, link-check ✅. Remaining pending checks (license, docs, Docker) are unaffected by an import-only change.
6 Silent failure risk None — ImportError is loud and immediate. No risk of subtle behavioral change since the operation default is "add" in the base class.

Verdict

LGTM — Straightforward, correct fix. No side effects or silent failure risks detected. The only suggestion is a follow-up PR to sweep remaining AdditiveUniformNoiseCfg references across the repo.


Automated review by isaaclab-review-botPR #6032

@ooctipus

ooctipus commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

Closing this beta2-targeted PR in favor of landing the fix on develop first: #6033. Once the develop fix merges, it can be cherry-picked/backported to release/3.0.0-beta2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant