Fix quadruped tutorial noise import#6032
Conversation
Greptile SummaryThis PR fixes a broken import in the quadruped base tutorial script.
Confidence Score: 5/5Safe to merge — the change corrects a broken import that would prevent the tutorial from running at all, replacing it with the correct class that provides identical additive noise behavior. The old import AdditiveUniformNoiseCfg does not exist in the codebase, meaning the tutorial would immediately crash with an ImportError on any invocation. The fix uses UniformNoiseCfg, which is the correct class, is fully exported from the noise module, and defaults to the same additive operation. All six call sites in the file are unaffected. This is a single-line, targeted fix with no side effects. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["tutorial script startup"] --> B["import UniformNoiseCfg as Unoise\n(isaaclab.utils.noise)"]
B --> C["UniformNoiseCfg\noperation = 'add' (default)"]
C --> D["ObservationsCfg:\nUnoise used for 6 ObsTerm noise fields"]
D --> E["Additive noise applied\nto observations at runtime"]
subgraph "Before (broken)"
F["import AdditiveUniformNoiseCfg\n→ ImportError (class does not exist)"]
end
subgraph "After (fixed)"
G["import UniformNoiseCfg\n→ same additive behavior, correct API"]
end
Reviews (1): Last reviewed commit: "Fix quadruped tutorial noise import" | Re-trigger Greptile |
There was a problem hiding this comment.
🤖 Isaac Lab Review Bot — PR #6032
Summary
Single-line import fix in the quadruped base tutorial: replaces the removed AdditiveUniformNoiseCfg with the beta2-era UniformNoiseCfg.
Findings
| # | Severity | Category | Detail |
|---|---|---|---|
| 1 | ✅ | Correctness | UniformNoiseCfg exists in isaaclab.utils.noise on release/3.0.0-beta2 (confirmed in __init__.pyi and noise_cfg.py). AdditiveUniformNoiseCfg is not exported from the beta2 noise module, so the old import would raise ImportError at runtime. |
| 2 | ✅ | Behavior preservation | UniformNoiseCfg inherits from NoiseCfg which defaults operation = "add". All usages in this file (Unoise(n_min=..., n_max=...)) rely on additive noise — behavior is preserved exactly. |
| 3 | ✅ | API consistency | Other task/test configs on this branch (e.g., check_manager_based_env_anymal_locomotion.py) already use UniformNoiseCfg. This aligns the tutorial with the rest of the codebase. |
| 4 | ℹ️ | Scope note | ~14 other files in the repo still reference AdditiveUniformNoiseCfg (mostly in isaaclab_tasks). These likely need similar fixes but are reasonably out of scope for this targeted tutorial fix. Consider a follow-up sweep. |
| 5 | ℹ️ | CI status | pre-commit ✅, Build Wheel ✅, changelog check ✅, link-check ✅. Remaining pending checks (license, docs, Docker) are unaffected by an import-only change. |
| 6 | ✅ | Silent failure risk | None — ImportError is loud and immediate. No risk of subtle behavioral change since the operation default is "add" in the base class. |
Verdict
LGTM — Straightforward, correct fix. No side effects or silent failure risks detected. The only suggestion is a follow-up PR to sweep remaining AdditiveUniformNoiseCfg references across the repo.
Automated review by isaaclab-review-bot • PR #6032
|
Closing this beta2-targeted PR in favor of landing the fix on develop first: #6033. Once the develop fix merges, it can be cherry-picked/backported to release/3.0.0-beta2. |
Summary
Validation
Full Kit launch was not run locally; this environment does not have the prepared Isaac Lab runtime dependencies installed.