Skip to content

Fix quadruped tutorial noise import#6033

Merged
ooctipus merged 1 commit into
isaac-sim:developfrom
ooctipus:fix/quadruped-noise-import
Jun 8, 2026
Merged

Fix quadruped tutorial noise import#6033
ooctipus merged 1 commit into
isaac-sim:developfrom
ooctipus:fix/quadruped-noise-import

Conversation

@ooctipus

@ooctipus ooctipus commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Update the quadruped base tutorial to import UniformNoiseCfg, which is the current noise config API used elsewhere in the repo.
  • Preserve behavior: UniformNoiseCfg defaults to additive noise, matching the tutorial usage.

Validation

  • python3 -m py_compile scripts/tutorials/03_envs/create_quadruped_base_env.py
  • pre-commit run --files scripts/tutorials/03_envs/create_quadruped_base_env.py
  • python3 tools/changelog/cli.py check develop

Full Kit launch was not run locally; this environment does not have the prepared Isaac Lab runtime dependencies installed.

@github-actions github-actions Bot added bug Something isn't working isaac-lab Related to Isaac Lab team labels Jun 8, 2026
@greptile-apps

greptile-apps Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a broken import in the quadruped base tutorial by replacing the no-longer-exported AdditiveUniformNoiseCfg alias with UniformNoiseCfg, which is the current public API in isaaclab.utils.noise. Runtime behavior is preserved because UniformNoiseCfg inherits operation="add" from NoiseCfg by default.

  • Replaces from isaaclab.utils.noise import AdditiveUniformNoiseCfg as Unoise with from isaaclab.utils.noise import UniformNoiseCfg as Unoise — the old symbol no longer exists in the module, so this change is necessary for the script to import cleanly.
  • All six Unoise(...) call-sites in ObservationsCfg.PolicyCfg continue to work without modification, as the constructor signature (n_min, n_max) and default additive operation are identical.

Confidence Score: 5/5

Safe to merge — one-line import fix restoring a working tutorial.

The old AdditiveUniformNoiseCfg symbol is absent from the entire codebase, so the previous import would fail on load. UniformNoiseCfg is the correct current export and carries the same additive default, so no functional difference exists. The change is minimal, self-contained, and correct.

No files require special attention.

Important Files Changed

Filename Overview
scripts/tutorials/03_envs/create_quadruped_base_env.py Replaces the removed AdditiveUniformNoiseCfg import alias with the current UniformNoiseCfg; behavior is identical since UniformNoiseCfg defaults to additive (operation="add").

Sequence Diagram

sequenceDiagram
    participant Tutorial as create_quadruped_base_env.py
    participant Noise as isaaclab.utils.noise
    participant ObsMgr as ObservationManager

    Tutorial->>Noise: import UniformNoiseCfg as Unoise
    Note over Noise: UniformNoiseCfg(NoiseCfg)<br/>operation="add" (default)
    Tutorial->>ObsMgr: "ObsTerm(noise=Unoise(n_min=..., n_max=...))"
    ObsMgr->>Noise: uniform_noise(tensor, cfg)
    Noise-->>ObsMgr: tensor + uniform sample in [n_min, n_max]
Loading

Reviews (1): Last reviewed commit: "Fix quadruped tutorial noise import" | Re-trigger Greptile

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Isaac Lab Review Bot — PR #6033

Summary: Import fix replacing deprecated AdditiveUniformNoiseCfg with UniformNoiseCfg in the quadruped tutorial.

✅ Verdict: LGTM

Findings (0 issues):

Check Result
Import path valid on develop UniformNoiseCfg is exported from isaaclab.utils.noise in __init__.pyi
Class exists in source ✅ Defined in noise_cfg.py
Behavior preserved UniformNoiseCfg defaults operation="add", matching the old AdditiveUniformNoiseCfg semantics
Tutorial usage compatible ✅ All usages pass only n_min/n_max kwargs, which are supported by UniformNoiseCfg
CI status pre-commit and Build Wheel pass; remaining checks pending/skipping (infra)
Scope ✅ Single-line change, tutorial-only, no production code affected

Notes:

  • AdditiveUniformNoiseCfg does not appear in the canonical __init__.pyi exports on develop, confirming it is deprecated/removed from the public API.
  • The alias as Unoise is preserved, so all downstream usages in the file remain valid without modification.

No issues found. Clean bug fix. 🎉

@ooctipus ooctipus merged commit bde6e2d into isaac-sim:develop Jun 8, 2026
37 checks passed
ooctipus added a commit that referenced this pull request Jun 9, 2026
## Summary
- Backports #6033 to `release/3.0.0-beta2`.
- Updates the quadruped tutorial noise import from
`AdditiveUniformNoiseCfg` to `UniformNoiseCfg`.

## Source
- Upstream PR: #6033
- Source commit: 8f701c3

## Tests
- `git diff --check upstream/release/3.0.0-beta2..HEAD`
- Parsed `scripts/tutorials/03_envs/create_quadruped_base_env.py` with
`ast.parse`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants