Fix quadruped tutorial noise import#6033
Conversation
Greptile SummaryThis PR fixes a broken import in the quadruped base tutorial by replacing the no-longer-exported
Confidence Score: 5/5Safe to merge — one-line import fix restoring a working tutorial. The old AdditiveUniformNoiseCfg symbol is absent from the entire codebase, so the previous import would fail on load. UniformNoiseCfg is the correct current export and carries the same additive default, so no functional difference exists. The change is minimal, self-contained, and correct. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Tutorial as create_quadruped_base_env.py
participant Noise as isaaclab.utils.noise
participant ObsMgr as ObservationManager
Tutorial->>Noise: import UniformNoiseCfg as Unoise
Note over Noise: UniformNoiseCfg(NoiseCfg)<br/>operation="add" (default)
Tutorial->>ObsMgr: "ObsTerm(noise=Unoise(n_min=..., n_max=...))"
ObsMgr->>Noise: uniform_noise(tensor, cfg)
Noise-->>ObsMgr: tensor + uniform sample in [n_min, n_max]
Reviews (1): Last reviewed commit: "Fix quadruped tutorial noise import" | Re-trigger Greptile |
There was a problem hiding this comment.
🤖 Isaac Lab Review Bot — PR #6033
Summary: Import fix replacing deprecated AdditiveUniformNoiseCfg with UniformNoiseCfg in the quadruped tutorial.
✅ Verdict: LGTM
Findings (0 issues):
| Check | Result |
|---|---|
Import path valid on develop |
✅ UniformNoiseCfg is exported from isaaclab.utils.noise in __init__.pyi |
| Class exists in source | ✅ Defined in noise_cfg.py |
| Behavior preserved | ✅ UniformNoiseCfg defaults operation="add", matching the old AdditiveUniformNoiseCfg semantics |
| Tutorial usage compatible | ✅ All usages pass only n_min/n_max kwargs, which are supported by UniformNoiseCfg |
| CI status | ✅ pre-commit and Build Wheel pass; remaining checks pending/skipping (infra) |
| Scope | ✅ Single-line change, tutorial-only, no production code affected |
Notes:
AdditiveUniformNoiseCfgdoes not appear in the canonical__init__.pyiexports ondevelop, confirming it is deprecated/removed from the public API.- The alias
as Unoiseis preserved, so all downstream usages in the file remain valid without modification.
No issues found. Clean bug fix. 🎉
## Summary - Backports #6033 to `release/3.0.0-beta2`. - Updates the quadruped tutorial noise import from `AdditiveUniformNoiseCfg` to `UniformNoiseCfg`. ## Source - Upstream PR: #6033 - Source commit: 8f701c3 ## Tests - `git diff --check upstream/release/3.0.0-beta2..HEAD` - Parsed `scripts/tutorials/03_envs/create_quadruped_base_env.py` with `ast.parse`
Summary
Validation
Full Kit launch was not run locally; this environment does not have the prepared Isaac Lab runtime dependencies installed.