Html tour #16
Closed
Html tour #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 25, 2017 16:15
updating markup to fit brand
Added src/lib/plugin/HTMLtour directory for new plugin Updated corresponding module names and file paths
This reverts commit 9ca2eaf.
Template is now in an individual file, updated markup a little bit Added “.html-popover” class to the popover for more control of styles
|
Thanks for submitting a PR back. This is definitely useful as a reference for other people that might want to create their own plugins, but I don't think other people will necessarily want the specific html changes you made. So I'll close the PR. I'm glad you got it working for your use case. Sidenote: I'm not sure if this is still the case, but it used to be that Angular libraries needed to have templates inline in the components in order for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added HTMLtour to plugins/
Moved the HTML outside of the component.ts file with updated markup