Add remove() from the middle, along with insertBefore() and insertAfter() given item #5

Open
OJezu opened this Issue Jan 22, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@OJezu

OJezu commented Jan 22, 2014

I've added a couple of changes as listed in the title to the code. See here: OJezu/fast-list@5606a22

I needed a structure that allowed me to keep entries in an order, while allowing me to remove some arbitrary entries from the middle. I found this double-linked list, and added some functions and altering the ones already present. I changed push() and unshift(), so that they return a reference that can be later given to the new functions above, in order to insert/remove elements into/from the middle of the list.

I would like to add one more (or two) benchmark, and update the doc. I should have a pull request ready tomorrow.

What do you think?

@isaacs

This comment has been minimized.

Show comment Hide comment
@isaacs

isaacs Jan 22, 2014

Owner

Sure, sounds reasonable. Add docs, and pull req welcome. Please match the semicolon styling of the rest of the file, though.

Owner

isaacs commented Jan 22, 2014

Sure, sounds reasonable. Add docs, and pull req welcome. Please match the semicolon styling of the rest of the file, though.

OJezu pushed a commit to OJezu/fast-list that referenced this issue Jan 23, 2014

Krzysztof Chrapka
Add insert benchmark and update readme
Also try adjust to original semi-colon style

Closes #5

OJezu pushed a commit to OJezu/fast-list that referenced this issue Jan 23, 2014

Krzysztof Chrapka
Add insert benchmark and update readme
Also try adjust to original semi-colon style

Closes #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment