-
Notifications
You must be signed in to change notification settings - Fork 129
Notifications on Comment or PR Description Edit #310
Comments
I'd love an update on this. |
For me, the notification is not the core concern, in fact, it might be rather annoying; despite how infrequently it should be used, there are lots of edits in practice for typos, clarity, etc. Rather, what I'd like is the ability to see, on demand, the version history of an issue. |
Made a new issue here: #954 |
I don't know if they should be on by default, but I believe when someone edits a comment to add an "@mention" it should trigger the "participant" email setting. |
I agree to @jmcmurry |
So has this been added? |
I want this! |
In my very recent experience (from earlier today), it seems that editing a comment to add a username does generate an email notification for the mentioned user and add them as a watcher (so far as I'm aware my notifications are on default settings): Further, in (admittedly limited) testing, subsequent edits to the same comment do not generate further notifications for the mentioned user (which I'd call desirable behaviour). |
Seems to work as described by @tullyhansen. IMO, this issue can be closed. |
Notification when an @mention is added should be added (seems to have been added), but notifications for edits in general might be excessive/unnecessary, or off by default. |
Well, having them off by default is the best way IMO. Excessive, possibly,
but having an option to have them would be nice.
…On Thu, Jul 18, 2019 at 5:43 PM Erik Humphrey ***@***.***> wrote:
Notification when an @mention is added should be added (seems to have been
added), but notifications for edits in general might be excessive, or off
by default.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#310?email_source=notifications&email_token=AIOR6KBWFVUDESIPCMMM2UTQAB6SZA5CNFSM4AYED4R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2IWS3A#issuecomment-512846188>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIOR6KDAJ5JQ45DR623DPTLQAB6SZANCNFSM4AYED4RQ>
.
|
First off, let me mention that I use a Github Enterprise instance where I work more often than Github proper, so if this is fixed already and I just need to wait for Enterprise to be updated, I'll close this issue.
I can find no method for enabling notifications, specifically email, when a comment or pull request description is edited.
The most egregious oversight is when someone edits to add an @mention, and that person does not receive an email.
I feel that notifications on edits should be the default. A method for opting out of this notification type may not even be necessary given the infrequency of which editing should normally occur.
The text was updated successfully, but these errors were encountered: