Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Notifications on Comment or PR Description Edit #310

Open
neonphog opened this issue Nov 26, 2014 · 11 comments
Open

Notifications on Comment or PR Description Edit #310

neonphog opened this issue Nov 26, 2014 · 11 comments

Comments

@neonphog
Copy link

First off, let me mention that I use a Github Enterprise instance where I work more often than Github proper, so if this is fixed already and I just need to wait for Enterprise to be updated, I'll close this issue.

I can find no method for enabling notifications, specifically email, when a comment or pull request description is edited.

The most egregious oversight is when someone edits to add an @mention, and that person does not receive an email.

I feel that notifications on edits should be the default. A method for opting out of this notification type may not even be necessary given the infrequency of which editing should normally occur.

@jononomo
Copy link

I'd love an update on this.

@jmcmurry
Copy link

jmcmurry commented Jun 9, 2017

For me, the notification is not the core concern, in fact, it might be rather annoying; despite how infrequently it should be used, there are lots of edits in practice for typos, clarity, etc. Rather, what I'd like is the ability to see, on demand, the version history of an issue.

@jmcmurry
Copy link

jmcmurry commented Jun 9, 2017

Made a new issue here: #954

@SxMShaDoW
Copy link

I don't know if they should be on by default, but I believe when someone edits a comment to add an "@mention" it should trigger the "participant" email setting.

@hsxfjames
Copy link

hsxfjames commented Feb 18, 2018

I agree to @jmcmurry
But I have another suggestion: people should be able to decide whether their edit notify all the subscribers or not, by providing a option after edit.
This will make sense if someone edits a comment just for typo, he may not want to annoy others. And if someone edits so many times maliciously to annoy others, he can also achieve by making many new comments. A sensible person could decide the notification by himself.

@qwertyquerty
Copy link

So has this been added?

@Nightquaker
Copy link

I want this!

@tullyhansen
Copy link

tullyhansen commented Sep 2, 2018

In my very recent experience (from earlier today), it seems that editing a comment to add a username does generate an email notification for the mentioned user and add them as a watcher (so far as I'm aware my notifications are on default settings):

image

Further, in (admittedly limited) testing, subsequent edits to the same comment do not generate further notifications for the mentioned user (which I'd call desirable behaviour).

@karlb
Copy link

karlb commented Apr 29, 2019

Seems to work as described by @tullyhansen. IMO, this issue can be closed.

@ErikHumphrey
Copy link

ErikHumphrey commented Jul 18, 2019

Notification when an @mention is added should be added (seems to have been added), but notifications for edits in general might be excessive/unnecessary, or off by default.

@Nightquaker
Copy link

Nightquaker commented Jul 19, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests