New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a CONTRIBUTING.md that is a symlink is present, the link to it should not show on new issue forms. #348

Open
cirosantilli opened this Issue Feb 1, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@cirosantilli
Collaborator

cirosantilli commented Feb 1, 2015

https://github.com/cirosantilli/test-symlink-contributing/issues/new

The "Please review the guidelines for contributing to this repository." should not appear in this case, just like the README.md does not appear for submodules.

Works as expected for submodules: https://github.com/cirosantilli/test-submodule-contributing/issues/new and does not show.

@stuartpb

This comment has been minimized.

stuartpb commented Feb 25, 2015

Alternately, if it points sensibly to a file, they should change the UI to link to the file that the symlink points to.

I'll make a revision to https://github.com/ghes/contributing-includer/blob/gh-pages/contributing.user.js to implement this.

@cirosantilli

This comment has been minimized.

Collaborator

cirosantilli commented Feb 25, 2015

@stuartpb yes, that would be good as well. If implemented by GitHub, it would only require some security checks like path transversal and .git access. And if recursive symlinks are enabled, infinite symlink loops.

@cirosantilli

This comment has been minimized.

Collaborator

cirosantilli commented Aug 25, 2015

GitHub implemented it silently as it does for such small features.

@stuartpb

This comment has been minimized.

stuartpb commented Aug 25, 2015

Did they? It looks like it's still pointing at the symlink itself for me.

@cirosantilli

This comment has been minimized.

Collaborator

cirosantilli commented Aug 26, 2015

@stuartpb going nuts, nothing is changed.

@cirosantilli cirosantilli reopened this Aug 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment