New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit `+1` feature for issues that isn't a comment #9

Closed
isaacs opened this Issue Jun 4, 2013 · 387 comments

Comments

Projects
None yet
@isaacs
Owner

isaacs commented Jun 4, 2013

Often people post github issue comments like 馃憤 just so that they can get notified when there are updates, and to indicate that they are also interested in an issue.

It'd be nice if they could just click a thing to do that, without posting a comment that emails everyone else uselessly. It could even put the 馃憤 comment on the page for cute factor if you feel that's important, but without emailing everyone.

For bonus points, let the project maintainers sort the issues list by the number of votes.

Then the 馃憤 behavior would be useful, rather than spammy.


Update: (there's a Change.org petition for this now](https://www.change.org/p/github-inc-add-voting-functionality-for-github-issues)

@ericf

This comment has been minimized.

ericf commented Jun 4, 2013

+1

@isaacs

This comment has been minimized.

Owner

isaacs commented Jun 4, 2013

@ericf I see what you did there. ;P

@sarahhodne

This comment has been minimized.

sarahhodne commented Jun 4, 2013

Such a button already exists:

screen shot 2013-06-04 at 8 15 32 pm

It might be made more prominent, though.

@polotek

This comment has been minimized.

polotek commented Jun 4, 2013

@henrikhodne I'm not sure if people think of watches as an indicator of importance on issues. To me it just means I want to get emails about new comments. It can probably be repurposed to have more meaning though.

@imakewebthings

This comment has been minimized.

imakewebthings commented Jun 4, 2013

@henrikhodne I think what @isaacs wants is a distinction between watchers and a vote of support for the ticket. The Chrome bug tracker does this with "starring" an issue. They may be an interesting case to study because despite that feature they still get a ton of +1 style comments. I think in part because the star is not featured prominently, not explained in any way inline, and generally is not a good representation of what it means.

@sarahhodne

This comment has been minimized.

sarahhodne commented Jun 4, 2013

Ah, sorry, I missed that there were two parts to the issue, I only read "make a button so we don't have to comment 馃憤 to get notifications".

@isaacs

This comment has been minimized.

Owner

isaacs commented Jun 4, 2013

@henrikhodne Yeah, also, there's no way to sort the issues list by the number of watchers, and maybe it could be set up so that the watch link is closer to the "comment" button, and a sort option in the issues list, or a variety of other potential approaches. It would also be nice to not send us all an email for comments that are just an emoticon, maybe. I'm not sure the best way to do this, but it seems like the functionality and data is there, and some relatively minor adjustments could make it much more useful.

@dresende

This comment has been minimized.

dresende commented Jun 5, 2013

+1

@jsocol

This comment has been minimized.

jsocol commented Jun 5, 2013

Is there any way to expose the number of watchers? "Participants" only includes people who comment.

+1 to the 馃憤 button, though if nothing else, at least in the short term, saying "6 participants and 18 watchers" would be helpful.

@jzaefferer

This comment has been minimized.

jzaefferer commented Jun 11, 2013

On Chromium, maintainers are suspicious of issues that get a few dozen stars within a day, blaming the reporter to have a "huge twitter following".

@polotek

This comment has been minimized.

polotek commented Jun 12, 2013

Ha, does that somehow make the data less valid?

On Tue, Jun 11, 2013 at 3:15 PM, J枚rn Zaefferer notifications@github.comwrote:

On Chromium, maintainers as suspicious of issues that get a few dozen
starts within a day, blaming the reporter to have a "huge twitter
following".


Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-19296086
.

Marco Rogers
marco.rogers@gmail.com | https://twitter.com/polotek

Life is ten percent what happens to you and ninety percent how you respond
to it.

  • Lou Holtz
@zwn

This comment has been minimized.

zwn commented Sep 19, 2013

馃憤

@patcon

This comment has been minimized.

patcon commented Sep 19, 2013

Can we separate this out into separate issues? As it stands, I want to express my support for some things mentioned here, but some of it feels like feature creep.

Here's what I see for issue candidates:

  • I want a way to watch a thread without needing to comment/+1 DONE
  • I want a way to +1 an issue without inflating comment count (and presumably without notifying others)
  • I want a way to sort issues by watchers.
  • I want the option to not get notifications on +1 comments (or comment below a char threshold?)

Did I miss anything here?

@fgrehm

This comment has been minimized.

fgrehm commented Sep 19, 2013

We used to have "upvotes" or something similar in a remote past but it ended up getting removed.

old

From http://blog.leahculver.com/2009/04/github-issues.html

@carols10cents

This comment has been minimized.

carols10cents commented Oct 24, 2013

I want a way to sort issues by watchers.

OR sort issues by 馃憤 votes, if that functionality is made independent from watching. People might want to leave a 馃憤 to indicate that they're experiencing that issue too, or they agree with the idea, but don't want to get notifications-- I suppose it's up for debate which number would be a better metric for user pain/need.

@patcon

This comment has been minimized.

patcon commented Oct 24, 2013

Someone could write a simple service and create a browser extension/userscript:
http://developer.github.com/v3/search/#search-issues

I feel like particular approach as passionate github users who want niche features :) (see #93 (comment))

@ndarville

This comment has been minimized.

ndarville commented Dec 4, 2013

馃憤

@captn3m0

This comment has been minimized.

captn3m0 commented Dec 4, 2013

A Chrome extension for GitHub, Zenhub offers a plus-one feature. Screenshot:

screenshot

@constantx

This comment has been minimized.

constantx commented Dec 7, 2013

hey @isaacs, +1 feature 鈥 and a kanban-like board for GitHub Issues 鈥 are implemented in ZenHub Chrome Extension

Give it a try :) http://www.zenhub.io/beta

* Disclosure: I work on ZenHub :)

zombie-careers___board

@roham

This comment has been minimized.

roham commented Dec 8, 2013

We made a quick screen-cast showing ZenHub in action:

Note the +1 buttons, the customizable Boards, and file uploads to S3, all injected into GitHub via the ZenHub browser extension. The link @constantx shared will allow anyone interested in this thread to sign up (for free): http://www.zenhub.io/beta

Take us for a spin and let us know what you think on our public repo. Sorting by +1 is coming 馃敎

Most of all: thanks for bringing us up, @captn3m0 - it's great to see our early users evangelizing the product! Makes us want to work even harder :shipit:

@Mithgol

This comment has been minimized.

Mithgol commented Dec 9, 2013

People would still use traditional 馃憤 comments because they聽are spammy. To聽nag over聽stuff so the聽developer would聽notice.

@juliangruber

This comment has been minimized.

juliangruber commented Dec 9, 2013

good point, but the community will likely take care of that as it would be considered very rude.

@daveswartz daveswartz referenced this issue Jan 5, 2014

Closed

sbt 0.13 #15

@felipesabino

This comment has been minimized.

felipesabino commented Jan 28, 2014

@Mithgol @isaacs may be something like stackoverflow comments minimum characters restriction could work to prevent spammy comments

screenshot 2014-01-28 15 38 43

@rlidwka

This comment has been minimized.

rlidwka commented Jan 29, 2014

may be something like stackoverflow comments minimum characters restriction

"+1, I like that"

@diosney

This comment has been minimized.

diosney commented Jan 31, 2014

+1 :)

I like very much the Bitbucket voting feature.

@lexoyo

This comment has been minimized.

lexoyo commented Feb 1, 2014

馃憤

@roham

This comment has been minimized.

roham commented Feb 1, 2014

... have you seen ZenHub? This thread - and the annoying notifications we are getting from people's +1s - are perfect examples why everyone should be using ZenHub.

We have now made the decision to make ZenHub free, forever, for everyone. So don't be shy, check it out: http://www.zenhub.io

And then come back to this thread to see all the glorious +1s already populated here!

@impaler

This comment has been minimized.

impaler commented Feb 5, 2014

+1 for an optional voting system for issues. Almost every other issue system I use has it and users sure love it. I would love to hear some rationale as to why it was removed or why it wont be added other than feature bloat.

@curtiszimmerman

This comment has been minimized.

curtiszimmerman commented Mar 12, 2016

But can we SORT by reactions?! Negative.

@rummik

This comment has been minimized.

rummik commented Mar 21, 2016

@TPS I don't think it should be closed off until we have a way to sort issues by reactions, since that can be considered crucial to a voting system

@dmitshur

This comment has been minimized.

dmitshur commented Mar 21, 2016

I don't think it should be closed off until we have a way to sort issues by reactions, since that can be considered crucial to a voting system

@rummik The original issue title is "Add explicit +1 feature for issues that isn't a comment". In the description, it mentions voting/sorting as a bonus:

For bonus points, let the project maintainers sort the issues list by the number of votes.

So this issue being closed is quite fair. There's issue #600 that tracks ability to sort issues by votes, etc.

@rummik

This comment has been minimized.

rummik commented Mar 21, 2016

@shurcooL My response was was in reference to the Change.org petition that was mentioned by TPS. I agree that this issue should be closed, since reactions do fulfill the issue text

@TPS

This comment has been minimized.

TPS commented Mar 22, 2016

@rummik Just put up another petition for that.... 馃槃

@TPS

This comment has been minimized.

TPS commented Mar 24, 2016

All you sorting-by-卤1 gripers can rest easy now. To quote (myself 馃槣) from #600 (comment):

This now seems to be solved (& then some 鈥 sort by any of the supplied reactions!), e.g., for this repo, to sort open issues by most 馃憤s:

https://github.com/isaacs/github/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc

This is fully accessible by the typical issues-list sort-menu. 鈽

@joffrey-bion

This comment has been minimized.

joffrey-bion commented Mar 24, 2016

I would not say this is solved. There is still no actual issue upvoting. Just reactions to comments. I don't need reactions, I would like a voting system by issue. I'd like to sort my issues by upvotes minus downvotes count. What is preventing such a simple thing to happen? Is it much more complex than it sounds like?

@mitar

This comment has been minimized.

mitar commented Mar 24, 2016

Are those reactions exposed through the API? If so, then you can create any dashboard computing and sorting you want.

@sergei-ivanov

This comment has been minimized.

sergei-ivanov commented Mar 24, 2016

@TPS: I am afraid, it still does not cut it. Hence the petition will remain in place.

  1. When sorting by reactions, the number of reactions is not displayed in the list.
  2. It is still unclear whether the sorting takes into account the reactions on the headline comment only, or on all comments in the issue. If it is the latter, then it is pretty useless.
  3. I am still failing to see the point of using reactions as a pseudo-voting functionality. In my view, they provide a social aspect that is orthogonal or complementary to voting. I am still struggling to understand why a simple up/down voting system on the issue level cannot be implemented.
@howardroark

This comment has been minimized.

howardroark commented Apr 2, 2016

This project could help satisfy this want in the short term ... https://gitsup.com/isaacs/github :)

@TPS

This comment has been minimized.

TPS commented Apr 9, 2016

@sergei-ivanov & all other gripers: If you have a problem with closing this issue as solved, I'll bet y'all will hate #640. Check it out & let me know what you think. 馃槣

@vsiegel

This comment has been minimized.

vsiegel commented Jun 5, 2016

I'm clearly opposed to per comment voting, because of the clutter;
But it seems useful to be able to state that an issue is important to one person more,
i.e. me, experiencing it too.

For this, the way launchpad.net does it seems to be brilliant:

Assuming you are logged in and have at least minimal write access
to the system, directly after registering:

There is a link text
This bug affects 109 people, but not you. (Edit)

with a pop up
Does this bug affect you?
Yes, it affects me
No, it doesn't affect me

Selecting "Yes...: adds one and changes the link text to
This bug affects you and 110 other people (Edit)

The UI when logged in is shown in the next two screen shots:

launchpad-bug-page-logged-in

launchpad-bug-page-logged-in-popup


If you are not logged in, the message reads:

This bug affects 109 people, but not you

which is not linked and has no edit button - but somehow suggests that you may
edit it when logged in.

launchpad-bug-page-not-logged-in

I think it's important that all this does not even resemble a "+1" or "like".
It's technically very similar, but the psychological model is quite different, which makes me hope it does not provoke the same unwanted behavior by analogy.

For full context, see example top left, either logged in or not.

@dmitshur

This comment has been minimized.

dmitshur commented Jun 5, 2016

@vsiegel That link results in 404 for me. Perhaps one needs to be logged in to see it. Maybe should post a screenshot too.

@vsiegel

This comment has been minimized.

vsiegel commented Jun 5, 2016

@shurcooL
Right - first, I was logged in, which changes that part of the UI; I will extend the above comment to explain.

Also, - second part -: I somehow had added an additional character "l" (small L) at the end of the of the URL, which broke it, sorry. Corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment