Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Relax minimatch.match about 'option' argument #24

Closed
wants to merge 1 commit into from

2 participants

@litmit

All minimatch API (except minimatch.match) relaxed about option argument.
Fix minimatch.match calling convention please.

@isaacs
Owner

Landed on 9be6a33. Thanks!

@isaacs isaacs closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 14, 2014
  1. @litmit
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +1 −1  minimatch.js
  2. +1 −1  test/defaults.js
View
2  minimatch.js
@@ -817,7 +817,7 @@ minimatch.match = function (list, pattern, options) {
list = list.filter(function (f) {
return mm.match(f)
})
- if (options.nonull && !list.length) {
+ if (mm.options.nonull && !list.length) {
list.push(pattern)
}
return list
View
2  test/defaults.js
@@ -237,7 +237,7 @@ tap.test("basic tests", function (t) {
var pattern = c[0]
, expect = c[1].sort(alpha)
- , options = c[2] || {}
+ , options = c[2]
, f = c[3] || files
, tapOpts = c[4] || {}
Something went wrong with that request. Please try again.