Skip to content

Maybe mention in description that it's not "monkey-patching' anymore? #13

Closed
myrne opened this Issue Apr 10, 2013 · 5 comments

4 participants

@myrne
myrne commented Apr 10, 2013

Description says "fs monkey-patching to avoid EMFILE and other problems".
As far as I can tell, graceful-fs functions as a kind of proxy for regular fs module, but doesn't change it.

@isaacs
Owner
@andrewrk

This can be closed now. It's monkey patching again. You can't use graceful-fs without affecting the rest of your codebase.

@isaacs
Owner
isaacs commented Oct 15, 2013

Yeah, there's no way to make it work without monkey patching, unfortunately.

@isaacs isaacs closed this Oct 15, 2013
@balupton

Considering this, why isn't this part of the core? I don't understand why we have to include a module to avoid errors.

@andrewrk

It would be really handy if there were an option to enable this behavior, for example, when creating a fs.WriteStream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.