Ensure curOpen decrements if open call fails. #8

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

mojit0 commented Jul 28, 2012

Without this patch some uses of glob.js, which brings in graceful-fs, will hang during file operations.

This patch fixes isaacs/node-glob#46 based on my testing.

Owner

isaacs commented Jul 28, 2012

Nice find, thanks!

The problem with that patch is that it will obscure the error from being thrown. Fixed a different way on 3f39130. Published as 1.1.10

isaacs closed this Jul 28, 2012

mojit0 commented Jul 28, 2012

True. Should either have thrown it again or done it without the overhead of a try/catch. Either way, thanks so much for the quick response!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment