Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixes to allow tap to run under --use_strict #101

Closed
wants to merge 1 commit into from

2 participants

@macmenot

No description provided.

@isaacs isaacs closed this pull request from a commit
@isaacs support 'use strict'
Closes #101, but with test
e47324d
@isaacs isaacs closed this in e47324d
@isaacs
Owner

Thanks for the nudge. Landed but with a test and using parseInt instead of decimal numbers with a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 8, 2014
  1. @macmenot
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 4 deletions.
  1. +4 −4 lib/tap-runner.js
View
8 lib/tap-runner.js
@@ -49,7 +49,7 @@ function Runner (options, cb) {
this.coverageOutDir = path.resolve(this.coverageOutDir)
this.getFilesToCover(filesToCover)
var self = this
- return mkdirp(this.coverageOutDir, 0755, function (er) {
+ return mkdirp(this.coverageOutDir, '0755', function (er) {
if (er) return self.emit("error", er)
self.run(dir, cb)
})
@@ -198,15 +198,15 @@ function runFiles(self, files, dir, cb) {
args.push(fileName)
} else {
// Check if file is executable
- if ((st.mode & 0100) && process.getuid) {
+ if ((st.mode & 4 /* 0100 */) && process.getuid) {
if (process.getuid() != st.uid) {
return cb()
}
- } else if ((st.mode & 0010) && process.getgid) {
+ } else if ((st.mode & 2 /* 0010 */) && process.getgid) {
if (process.getgid() != st.gid) {
return cb()
}
- } else if ((st.mode & 0001) == 0) {
+ } else if ((st.mode & 1 /* 0001 */) == 0) {
return cb()
}
}
Something went wrong with that request. Please try again.