Browse files

Patches floating on V8

Only SConstruct and build/common.gypi at this point.  All
others are accepted upstream, which greatly simplifies things.
  • Loading branch information...
1 parent 68a0c56 commit 5041bc1b6cc8c6424ed8dee41bd178187af7c094 @isaacs committed Feb 13, 2012
Showing with 1 addition and 3 deletions.
  1. +1 −2 deps/v8/SConstruct
  2. +0 −1 deps/v8/build/common.gypi
View
3 deps/v8/SConstruct
@@ -293,7 +293,6 @@ V8_EXTRA_FLAGS = {
'gcc': {
'all': {
'WARNINGFLAGS': ['-Wall',
- '-Werror',
@ry
ry added a note Feb 13, 2012

SConstruct isn't used in the GYP build - no need to float this patch anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
'-W',
'-Wno-unused-parameter',
'-Wnon-virtual-dtor']
@@ -390,7 +389,7 @@ MKSNAPSHOT_EXTRA_FLAGS = {
DTOA_EXTRA_FLAGS = {
'gcc': {
'all': {
- 'WARNINGFLAGS': ['-Werror', '-Wno-uninitialized'],
+ 'WARNINGFLAGS': ['-Wno-uninitialized'],
'CCFLAGS': GCC_DTOA_EXTRA_CCFLAGS
}
},
View
1 deps/v8/build/common.gypi
@@ -352,7 +352,6 @@
}], # OS=="mac"
['OS=="win"', {
'msvs_configuration_attributes': {
- 'OutputDirectory': '<(DEPTH)\\build\\$(ConfigurationName)',
@ry
ry added a note Feb 13, 2012

This still needs to be floated. Should push upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
'IntermediateDirectory': '$(OutDir)\\obj\\$(ProjectName)',
'CharacterSet': '1',
},

0 comments on commit 5041bc1

Please sign in to comment.