Permalink
Browse files

tls: Destroy socket when encrypted side closes

The v0.8 Stream.pipe() method automatically destroyed the destination
stream whenever the src stream closed.  However, this caused a lot of
problems, and was removed by popular demand.  (Many userland modules
still have a no-op destroy() method just because of this.) It was also
very hazardous because this would be done even if { end: false } was
passed in the pipe options.

In v0.10, we decided that the 'close' event and destroy() method are
application-specific, and pipe() doesn't automatically call destroy().
However, TLS actually depended (silently) on this behavior.  So, in this
case, we should just go ahead and destroy the thing when close happens.

Closes #5145
  • Loading branch information...
1 parent 7af075e commit 426de209dfc9200ed43b51c77414960b75264ecd @isaacs committed Mar 30, 2013
Showing with 6 additions and 0 deletions.
  1. +6 −0 lib/tls.js
View
6 lib/tls.js
@@ -1322,6 +1322,12 @@ function pipe(pair, socket) {
pair.encrypted.pipe(socket);
socket.pipe(pair.encrypted);
+ pair.encrypted.on('close', function() {
+ process.nextTick(function() {
+ socket.destroy();
+ });
+ });
+
pair.fd = socket.fd;
var cleartext = pair.cleartext;
cleartext.socket = socket;

0 comments on commit 426de20

Please sign in to comment.