Please sign in to comment.
test: fix flaky test-net-socket-timeout
The setTimeout() call is unneeded. If the socket never times out, then the test will never finish. Because timers can be unreliable on machines under load, using setTimeout() here effectively creates a race condition. PR-URL: nodejs#10172 Reviewed-By: Michael Dawson <firstname.lastname@example.org> Reviewed-By: Colin Ihrig <email@example.com> Reviewed-By: Santiago Gimeno <firstname.lastname@example.org>
- Loading branch information...
Showing with 14 additions and 15 deletions.