Permalink
Switch branches/tags
Commits on Dec 8, 2016
  1. test: fix flaky test-net-socket-timeout

    Trott committed Dec 7, 2016
    The setTimeout() call is unneeded. If the socket never times out, then
    the test will never finish. Because timers can be unreliable on machines
    under load, using setTimeout() here effectively creates a race
    condition.
    
    PR-URL: nodejs#10172
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
  2. doc: add some info on `tty#setRawMode()`

    Fishrock123 committed Dec 6, 2016
    Partially taken from https://linux.die.net/man/3/cfmakeraw
    
    A very simple test script:
    
    ```
    if (process.argv[2] === 'raw')
      process.stdin.setRawMode(true)
    
    process.stdin.on('data', (chunk) => {
      console.log(chunk)
      console.log(chunk.toString())
    })
    ```
    
    Refs: nodejs#10037
    PR-URL: nodejs#10147
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
  3. http: verify client method is a string

    lucamaraschi committed with cjihrig Dec 4, 2016
    Prior to this commit, it was possible to pass a truthy non-string
    value as the HTTP method to the HTTP client, resulting in an
    exception being thrown. This commit adds validation to the method.
    
    PR-URL: nodejs#10111
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  4. test: refactor test-net-keepalive.js

    kmccmk9 committed with cjihrig Dec 1, 2016
    - Replace require() vars with const.
    - Replace assert.equal() with assert.strictEqual().
    - Add common.mustCall() to the setTimeout() callback.
    
    PR-URL: nodejs#9995
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
  5. doc: update `path.format` description and examples

    anoff committed with Trott Dec 1, 2016
    * removed pseudo-code
    * added info on which properties have priority
    * modified examples to show ignored properties
    
    PR-URL: nodejs#10046
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
  6. test: refactor test-crypto-hmac

    eudaimos committed with Trott Dec 1, 2016
    * replace assert.equals with assert.strictEquals
    * use template strings where appropriate
    
    PR-URL: nodejs#9958
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  7. test: fix error in test-cluster-worker-death.js

    Bruce Lai committed with addaleax Dec 1, 2016
    Replaced calls to assert.equal with assert.strictEqual in order
    to fix the following error:
    "Please use assert.strictEqual() instead of assert.strictEqual()"
    
    PR-URL: nodejs#9981
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
  8. test: use `assert.strictEqual`

    anoff committed with addaleax Dec 1, 2016
    * use `assert.strictEqual`
    
    PR-URL: nodejs#9975
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
  9. test: change assert.equal to assert.strictEqual

    Aileen committed with addaleax Dec 1, 2016
    PR-URL: nodejs#9946
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
  10. test: changed assert.equal to assert.strictEqual

    vazina-robertson committed with addaleax Dec 1, 2016
    PR-URL: nodejs#10015
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
  11. test: renamed assert.Equal to assert.strictEqual

    Jared Young committed with addaleax Dec 1, 2016
  12. test: improves test-tls-client-verify

    homosaur committed with addaleax Dec 1, 2016
    Swaps var -> const/let
    assert.equal becomes assert.strictEqual
    common.mustCall on single-use functions
    
    PR-URL: nodejs#10051
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
  13. test: refactor test-https-agent-session-reuse

    dpaez committed with addaleax Dec 3, 2016
    Use const and let instead of var and assert.strictEqual() instead of
    assert.equal()
    
    PR-URL: nodejs#10105
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commits on Dec 7, 2016
  1. test: refactor test-beforeexit-event

    radelmann committed with addaleax Dec 4, 2016
    - replaced var with const/let.
    - removed all console.log() statements.
    - removed deaths and revivals vars.
    - wrapped beforexit listener callbacks with
      common.mustCall().
    - removed exit event listener.
    
    PR-URL: nodejs#10121
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  2. doc: adding missing - in README

    italoacasas committed Dec 7, 2016
    PR-URL: nodejs#10170
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  3. test: improve test-fs-read-stream.js

    jennabelle committed with Trott Nov 16, 2016
    var -> const
    assert.equal() -> assert.strictEqual()
    
    PR-URL: nodejs#9629
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
  4. doc: removing extra space in README

    italoacasas committed Dec 7, 2016
    PR-URL: nodejs#10168
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
  5. test: refactor test-domain-from-timer

    danielgsims committed with Trott Dec 1, 2016
    In this change, the setTimeout needed a second argument, so I set that
    value to 1. In addition, I changed the assertion to be a strictEquals
    instead of equals.
    
    I changed the var declarations to const in this test.
    
    PR-URL: nodejs#9889
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  6. test: refactor test-domain-exit-dispose-again

    Ethan-Arrowood committed with Trott Dec 1, 2016
    setTimeout at 49:5 requires two arguments.
    
    On lines 72 and 73 changed assert.equal() to assert.strictEqual().
    
    PR-URL: nodejs#10003
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  7. url: improve URLSearchParams spec compliance

    TimothyGu committed with italoacasas Nov 6, 2016
    - Make URLSearchParams constructor spec-compliant
    - Strip leading `?` in URL#search's setter
    - Spec-compliant iterable interface
    - More precise handling of update steps as mandated by the spec
    - Add class strings to URLSearchParams objects and their prototype
    - Make sure `this instanceof URLSearchParams` in methods
    
    Also included are relevant tests from W3C's Web Platform Tests
    (https://github.com/w3c/web-platform-tests/tree/master/url).
    
    Fixes: nodejs#9302
    PR-URL: nodejs#9484
    Reviewed-By: James M Snell <jasnell@gmail.com>
  8. test: use const and strictEqual in test-os-homedir-no-envvar

    codeVana committed with jasnell Dec 1, 2016
    PR-URL: nodejs#9899
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  9. test: check result of uv_loop_init and uv_write

    bnoordhuis committed with addaleax Dec 5, 2016
    Silence coverity warnings about the return value not being checked.
    
    PR-URL: nodejs#10126
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  10. build: fix node_g target

    danbev committed with addaleax Dec 6, 2016
    Currently when running make node_g the following error is displayed:
    if [ ! -r node -o ! -L  ]; then ln -fs out/Debug/node node_g; fi
    /bin/sh: line 0: [: argument expected
    
    It looks like there was a typo for the NODE_EXE where node became
    lowercase instead of uppercase.
    
    Ref: nodejs#9827
    PR-URL: nodejs#10153
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
  11. test: refactor test-dgram-bind-default-address

    mbchoa committed with italoacasas Dec 1, 2016
    - changes var to const/let
    - changes assert.equal to assert.strictEqual
    
    PR-URL: nodejs#9947
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  12. test: move long-running test to sequential

    Trott committed Dec 7, 2016
    test-buffer-creation-regression is flaky on some SmartOS hosts in CI,
    timing out. Move to sequential so it does not compete with other tests
    for resources. Reduce three test cases to just the one needed to
    identify the regression.
    
    PR-URL: nodejs#10161
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
  13. test: assert.throws() should include a RegExp

    cByst committed with Trott Dec 1, 2016
    PR-URL: nodejs#9976
    Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
  14. test: invalid package.json causes error when require()ing in directory

    samshull committed with italoacasas Dec 1, 2016
    Requiring a file from a directory that contains an invalid package.json
    file should throw an error.
    
    PR-URL: nodejs#10044
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  15. test: refactor test-listen-fd-ebadf

    Richard Karmazin committed with evanlucas Dec 1, 2016
    Replace var with const and assert.equal with assert.strictEqual.
    
    PR-URL: nodejs#10034
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
  16. test: refactor test-event-emitter-method-names

    Rodrigo Palma committed with evanlucas Dec 1, 2016
    Improved test by using strictEqual instead of equal.
    
    PR-URL: nodejs#10027
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
  17. test: refactor tls-ticket-cluster

    shri3k committed with mcollina Dec 1, 2016
    - changes var to const/let
    - changes assert.equal to assert.strictEqual
    - changes `notEqual` to `notStrictEqual`
    
    PR-URL: nodejs#10023
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  18. test: refactor test-domain-exit-dispose

    Chris Henney committed with Trott Dec 1, 2016
    change equal to strictEqual, fix setTimeout
    
    PR-URL: nodejs#9938
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
  19. test: refactor test-stdin-from-file.js

    amrios committed with Trott Dec 1, 2016
    change var to const/let
    wrap common.mustCall on childProcess.exec callback
    remove unneeded fs.unlinkSync()
    refactor assert.equal to assert.strictEqual
    
    PR-URL: nodejs#10012
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Commits on Dec 6, 2016
  1. inspector: split HTTP/WS server from the inspector

    eugeneo committed Nov 9, 2016
    Both our team experiments and some embedder request indicate a potential
    in implementing alternative transport for inspector - e.g. IPC pipes or
    custom embedder APIs. This change moves all HTTP specific code into a
    separate class and is a first attempt at defining a boundary between the
    inspector agent and transport. This API will be refined as new
    transports are implemented.
    Note that even without considering alternative transports, this change
    enables better testing of the HTTP server (Valgrind made it possible to
    identify and fix some existing memory leaks).
    
    PR-URL: nodejs#9630
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  2. 2016-12-06, Version 7.2.1 (Current)

    Fishrock123 committed Dec 6, 2016
    Notable changes:
    
    * buffer:
      - Reverted the runtime deprecation of calling `Buffer()` without
    `new`. (Anna Henningsen) nodejs#9529
      - Fixed `buffer.transcode()` for single-byte character
    encodings to `UCS2`. (Anna Henningsen)
    nodejs#9838
    * promise: `--trace-warnings` now produces useful stacktraces for
    Promise warnings. (Anna Henningsen)
    nodejs#9525
    * repl: Fixed a bug preventing correct parsing of generator functions.
    (Teddy Katz) nodejs#9852
    * V8: Fixed a significant `instanceof` performance regression.
    (Franziska Hinkelmann) nodejs#9730
    
    PR-URL: nodejs#10127
  3. inspector: check if connected before waiting

    eugeneo committed Dec 2, 2016
    Fixes: nodejs#10093
    PR-URL: nodejs#10094
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>