Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the selfLink a best effort if not explicitly true #30

Merged
merged 5 commits into from
Nov 4, 2023

Conversation

isaacs
Copy link
Owner

@isaacs isaacs commented Nov 4, 2023

This stops it from always failing on Windows which is making me so annoyed when I have to debug stuff on my windows VM.

Fix: #20

@isaacs isaacs force-pushed the isaacs/selflink-best-effort branch from c86ea27 to b7c6b62 Compare November 4, 2023 17:38
isaacs added a commit that referenced this pull request Nov 4, 2023
@isaacs isaacs force-pushed the isaacs/selflink-best-effort branch from 1abd48b to fb20e55 Compare November 4, 2023 17:45
It's not temporary if you use incremental:true in tsconfig
This stops it from always failing on Windows which is making me so
annoyed when I have to debug stuff on my windows VM.

Fix: #20
@isaacs isaacs force-pushed the isaacs/selflink-best-effort branch from fb20e55 to a3bccec Compare November 4, 2023 17:46
@isaacs isaacs merged commit a3bccec into main Nov 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should tshy.selfLink default to false on Windows?
1 participant