Topic/more scala fixes #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the last fix to case classes, types in the parameter list were not highlighting correctly. There were also some remaining issues with the delimiters being highlighted. This commit seems to allow parameters (and type parameters) to classes to be highlighted correctly in basically all styles.
This commit adds the .hljf-type class name to the 'vs' and 'hopscotch' styles. The lack of this makes the highlighting for Scala (and possibly other styles) less attractive.
|
Ugh sorry, looks like my changes messed up source detection. I'll try to figure out what happened. |
| @@ -73,10 +73,22 @@ function(hljs) { | |||
| relevance: 10 | |||
| }, | |||
| { | |||
| className: 'typeParams', | |||
There was a problem hiding this comment.
Looks like this should be just type or have no separate class name.
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some remaining issues with scala highlighting.
After the last fix to case classes, types in the
parameter list were not highlighting correctly.
There were also some remaining issues with the
delimiters being highlighted.
This PR cleans all that up, and contains small
fixes to two styles which lacked an important
class (
.hljs-type) which Scala needs.