mixable tree/map traits #1

Open
wants to merge 8 commits into
from

Projects

None yet

1 participant

@erikerlandson
Collaborator

A couple comments:

  1. As currently implemented, these have an algebird dependency, which means "isarn_collections" has an algebird dep.
  2. You can see I'm assuming we are going to use domain name "isarnproject.org"
  3. I'm using underscores in names "isarn_collections" because sbt isarn-collections/compile doesn't work, but isarn_collections/compile does
@erikerlandson
Collaborator
erikerlandson commented Aug 29, 2016 edited

Possibly it would help to just use % "provided" for the algebird lib.

Another approach might be to have our own internal algebra types, and require implicit conversions in the signatures, with a separate subproject for conversions from external algebra libs to ours. That gets rid of any external algebra lib deps and allows us to operate with multiple ones

A third option is to be opioninated wrt one of these algebra libs (I might favor cats these days), but require implicit conversions, and so allow other libs to interoperate. Would this allow us to not expose the dependency?

@erikerlandson
Collaborator

@willb I have the tree/map collections decoupled from algebird (except in testing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment