This repository has been archived by the owner on Nov 19, 2019. It is now read-only.
Make the build reproducible #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0] we noticed that isbg could not be built reproducibly. This is because it embeds the value of `xdg_cache_home` in the documentationwhich invariably points to something like: /home/lamby/.cache ... and thus varies depending on the build user. This was originally filed in Debian as #944520 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/944520
|
Hello, Thanks for this patch. I think this has already been fixed in ba91de9 and will be part of the next I didn't add a patch in Debian since 1.2.6 should be out soonish :) I'll close this for now, but if that patch doesn't work on your side, feel free to reopen it and tell us. Cheers, |
|
Oh nice, the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on the Reproducible Builds effort we noticed that isbg could not be built reproducibly.
This is because it embeds the value of
xdg_cache_homein the documentation which invariably points to something like/home/lamby/.cacheand thus varies depending on the build user.This was originally filed in Debian as #944520.