Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize request header #116

Merged
merged 3 commits into from Dec 17, 2015
Merged

Optimize request header #116

merged 3 commits into from Dec 17, 2015

Conversation

@chuganzy
Copy link
Contributor

chuganzy commented Dec 16, 2015

No description provided.

Takeru Chuganji added 2 commits Dec 16, 2015
handler(.Failure(error))
dispatch_async(dispatch_get_main_queue(), { () -> Void in
handler(.Failure(error))
})

This comment has been minimized.

Copy link
@ishkawa

ishkawa Dec 16, 2015

Owner

We prefer the following style:

dispatch_async(dispatch_get_main_queue()) {
    .Failure(error)
}

This comment has been minimized.

Copy link
@chuganzy

chuganzy Dec 17, 2015

Author Contributor

@ishkawa OK, and I've fixed it.

@chuganzy chuganzy changed the title Modify request header Optimize request header Dec 16, 2015
@@ -101,6 +101,7 @@ public extension RequestType {
default:
do {
URLRequest.HTTPBody = try requestBodyBuilder.buildBodyFromObject(parameters)
URLRequest.setValue(requestBodyBuilder.contentTypeHeader, forHTTPHeaderField: "Content-Type")

This comment has been minimized.

Copy link
@ishkawa
@ishkawa
Copy link
Owner

ishkawa commented Dec 16, 2015

Except for 1 note, looks good

Takeru Chuganji
@ishkawa
Copy link
Owner

ishkawa commented Dec 17, 2015

All changes make sense. Thank you for the pull request!

ishkawa added a commit that referenced this pull request Dec 17, 2015
Optimize request header
@ishkawa ishkawa merged commit 1d1a618 into ishkawa:master Dec 17, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chuganzy
Copy link
Contributor Author

chuganzy commented Dec 17, 2015

🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.