New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix percent encoding issues #118

Merged
merged 3 commits into from Jan 16, 2016

Conversation

Projects
None yet
2 participants
@chuganzy
Contributor

chuganzy commented Jan 12, 2016

No description provided.

@chuganzy chuganzy changed the title from Fix percent encoding issues to [WIP] Fix percent encoding issues Jan 12, 2016

@chuganzy chuganzy changed the title from [WIP] Fix percent encoding issues to Fix percent encoding issues Jan 12, 2016

@@ -3,7 +3,7 @@ import Foundation
private func escape(string: String) -> String {
// Reserved characters defined by RFC 3986
// Reference: https://www.ietf.org/rfc/rfc3986.txt
let generalDelimiters = ":/?#[]@"
let generalDelimiters = ":#[]@"

This comment has been minimized.

@chuganzy

chuganzy Jan 13, 2016

Contributor

"/" and "?" can be used within query components.

@chuganzy

chuganzy Jan 13, 2016

Contributor

"/" and "?" can be used within query components.

index = endIndex
}
return escaped

This comment has been minimized.

@ishkawa

ishkawa Jan 16, 2016

Owner

😨

@ishkawa

This comment has been minimized.

Show comment
Hide comment
@ishkawa

ishkawa Jan 16, 2016

Owner

Thank you!

Owner

ishkawa commented Jan 16, 2016

Thank you!

ishkawa added a commit that referenced this pull request Jan 16, 2016

@ishkawa ishkawa merged commit 652aa94 into ishkawa:master Jan 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment