Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix percent encoding issues #118

Merged
merged 3 commits into from Jan 16, 2016
Merged

Fix percent encoding issues #118

merged 3 commits into from Jan 16, 2016

Conversation

@chuganzy
Copy link
Contributor

chuganzy commented Jan 12, 2016

No description provided.

Takeru Chuganji added 2 commits Jan 12, 2016
@chuganzy chuganzy changed the title Fix percent encoding issues [WIP] Fix percent encoding issues Jan 12, 2016
Takeru Chuganji
@chuganzy chuganzy changed the title [WIP] Fix percent encoding issues Fix percent encoding issues Jan 12, 2016
@@ -3,7 +3,7 @@ import Foundation
private func escape(string: String) -> String {
// Reserved characters defined by RFC 3986
// Reference: https://www.ietf.org/rfc/rfc3986.txt
let generalDelimiters = ":/?#[]@"
let generalDelimiters = ":#[]@"

This comment has been minimized.

Copy link
@chuganzy

chuganzy Jan 13, 2016

Author Contributor

"/" and "?" can be used within query components.

index = endIndex
}

return escaped

This comment has been minimized.

Copy link
@ishkawa
@ishkawa
Copy link
Owner

ishkawa commented Jan 16, 2016

Thank you!

ishkawa added a commit that referenced this pull request Jan 16, 2016
Fix percent encoding issues
@ishkawa ishkawa merged commit 652aa94 into ishkawa:master Jan 16, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.