Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Remove unworkable video-buffering-repaints-controls test.

https://bugs.webkit.org/show_bug.cgi?id=83097

.:

Replaces the automated test for progress bar repaints during buffering
with a manual test entry.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-04-09
Reviewed by Eric Carlson.

* ManualTests/media-controls.html:

LayoutTests:

Test has been broken in one way or another for some time now. I've
approached multiple people about possible solutions, but nothing ends
up being stable.

After discussion with fischman and trying a couple more solutions
today, we decided the best course of action is to remove the test.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-04-09
Reviewed by Eric Carlson.

* http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
* http/tests/media/video-buffering-repaints-controls.html: Removed.
* platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
* platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
* platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
* platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
* platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
* platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
* platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
* platform/mac/Skipped:
* platform/mac/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information...
commit 4f71c922a29a3b39ae87f05313ed4c8c8be9041c 1 parent 05ec771
commit-queue@webkit.org authored

Showing 18 changed files with 52 additions and 90 deletions. Show diff stats Hide diff stats

  1. +12 0 ChangeLog
  2. +30 0 LayoutTests/ChangeLog
  3. +0 4 LayoutTests/http/tests/media/video-buffering-repaints-controls-expected.txt
  4. +0 34 LayoutTests/http/tests/media/video-buffering-repaints-controls.html
  5. BIN  LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png
  6. BIN  LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png
  7. BIN  LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png
  8. +0 4 LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt
  9. BIN  LayoutTests/platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png
  10. BIN  LayoutTests/platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png
  11. +0 3  LayoutTests/platform/chromium/test_expectations.txt
  12. +0 1  LayoutTests/platform/efl/Skipped
  13. +0 3  LayoutTests/platform/gtk/Skipped
  14. BIN  LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png
  15. +0 37 LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt
  16. +0 1  LayoutTests/platform/mac/Skipped
  17. +0 3  LayoutTests/platform/mac/test_expectations.txt
  18. +10 0 ManualTests/media-controls.html
12 ChangeLog
... ... @@ -1,3 +1,15 @@
  1 +2012-04-09 Dale Curtis <dalecurtis@chromium.org>
  2 +
  3 + Remove unworkable video-buffering-repaints-controls test.
  4 + https://bugs.webkit.org/show_bug.cgi?id=83097
  5 +
  6 + Replaces the automated test for progress bar repaints during buffering
  7 + with a manual test entry.
  8 +
  9 + Reviewed by Eric Carlson.
  10 +
  11 + * ManualTests/media-controls.html:
  12 +
1 13 2012-04-09 Ming Xie <mxie@rim.com>
2 14
3 15 [BlackBerry] Allow simulator to use GLES2 acceleration
30 LayoutTests/ChangeLog
... ... @@ -1,3 +1,33 @@
  1 +2012-04-09 Dale Curtis <dalecurtis@chromium.org>
  2 +
  3 + Remove unworkable video-buffering-repaints-controls test.
  4 + https://bugs.webkit.org/show_bug.cgi?id=83097
  5 +
  6 + Test has been broken in one way or another for some time now. I've
  7 + approached multiple people about possible solutions, but nothing ends
  8 + up being stable.
  9 +
  10 + After discussion with fischman and trying a couple more solutions
  11 + today, we decided the best course of action is to remove the test.
  12 +
  13 + Reviewed by Eric Carlson.
  14 +
  15 + * http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
  16 + * http/tests/media/video-buffering-repaints-controls.html: Removed.
  17 + * platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  18 + * platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  19 + * platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  20 + * platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
  21 + * platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  22 + * platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  23 + * platform/chromium/test_expectations.txt:
  24 + * platform/efl/Skipped:
  25 + * platform/gtk/Skipped:
  26 + * platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  27 + * platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
  28 + * platform/mac/Skipped:
  29 + * platform/mac/test_expectations.txt:
  30 +
1 31 2012-04-09 Sheriff Bot <webkit.review.bot@gmail.com>
2 32
3 33 Unreviewed, rolling out r113613.
4 LayoutTests/http/tests/media/video-buffering-repaints-controls-expected.txt
... ... @@ -1,4 +0,0 @@
1   -Test that media controls repaint correctly during paused states when new data is buffered.
2   -
3   -
4   -
34 LayoutTests/http/tests/media/video-buffering-repaints-controls.html
... ... @@ -1,34 +0,0 @@
1   -<html>
2   - <head>
3   - <script src="../../media-resources/media-file.js"></script>
4   - <script>
5   - function start() {
6   - if (window.layoutTestController) {
7   - layoutTestController.dumpAsText(true);
8   - layoutTestController.waitUntilDone();
9   - }
10   -
11   - var video = document.querySelector('video');
12   -
13   - video.addEventListener('progress', function(event) {
14   - layoutTestController.display();
15   - }, false);
16   -
17   - video.addEventListener('suspend', function(event) {
18   - layoutTestController.notifyDone();
19   - }, false);
20   -
21   - var mediaFile = findMediaFile("video", "resources/test");
22   - var mimeType = mimeTypeForFile(mediaFile);
23   -
24   - // Don't actually play since we're testing via an image diff.
25   - video.src = 'http://127.0.0.1:8000/media/video-throttled-load.cgi?&name=' + mediaFile + '&throttle=80&type=' + mimeType
26   - }
27   - </script>
28   - </head>
29   -
30   - <body onload="start();">
31   - <p>Test that media controls repaint correctly during paused states when new data is buffered.</p>
32   - <video controls preload></video><br/>
33   - </body>
34   -</html>
BIN  LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png
BIN  LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png
BIN  ...tTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png
4 ...tTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt
... ... @@ -1,4 +0,0 @@
1   -Test that media controls repaint correctly during paused states when new data is buffered.
2   -
3   -
4   -
BIN  LayoutTests/platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png
BIN  LayoutTests/platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png
3  LayoutTests/platform/chromium/test_expectations.txt
@@ -3265,9 +3265,6 @@ BUGWK76280 : media/W3C/video/networkState/networkState_during_progress.html = PA
3265 3265 BUGV81900 SLOW LINUX DEBUG : inspector/debugger/watch-expressions-panel-switch.html = PASS CRASH
3266 3266 BUGV81900 SLOW LINUX DEBUG : inspector/debugger/debugger-breakpoints-not-activated-on-reload.html = PASS CRASH
3267 3267
3268   -// New test, image results added but it is timing out on Leopard.
3269   -BUGWK75570 WIN LINUX : http/tests/media/video-buffering-repaints-controls.html = IMAGE
3270   -
3271 3268 // New reftest failing on Win7.
3272 3269 BUGWK76050 WIN7 : fast/text/font-kerning.html = IMAGE
3273 3270
1  LayoutTests/platform/efl/Skipped
@@ -2404,7 +2404,6 @@ http/tests/loading/slow-parsing-subframe.html
2404 2404 http/tests/loading/state-object-security-exception.html
2405 2405 http/tests/media/remove-while-loading.html
2406 2406 http/tests/media/video-buffered.html
2407   -http/tests/media/video-buffering-repaints-controls.html
2408 2407 http/tests/media/video-cancel-load.html
2409 2408 http/tests/media/video-cookie.html
2410 2409 http/tests/media/video-error-abort.html
3  LayoutTests/platform/gtk/Skipped
@@ -1526,9 +1526,6 @@ http/tests/download
1526 1526 fast/events/clear-drag-state.html
1527 1527 fast/events/clear-edit-drag-state.html
1528 1528
1529   -# https://bugs.webkit.org/show_bug.cgi?id=77019
1530   -http/tests/media/video-buffering-repaints-controls.html
1531   -
1532 1529 # https://bugs.webkit.org/show_bug.cgi?id=77413
1533 1530 fast/parser/nested-fragment-parser-crash.html
1534 1531
BIN  LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png
37 LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt
... ... @@ -1,37 +0,0 @@
1   -layer at (0,0) size 800x600
2   - RenderView at (0,0) size 800x600
3   -layer at (0,0) size 800x600
4   - RenderBlock {HTML} at (0,0) size 800x600
5   - RenderBody {BODY} at (8,8) size 784x584
6   - RenderBlock {P} at (0,0) size 784x18
7   - RenderText {#text} at (0,0) size 562x18
8   - text run at (0,0) width 562: "Test that media controls repaint correctly during paused states when new data is buffered."
9   - RenderBlock (anonymous) at (0,34) size 784x240
10   - RenderBR {BR} at (320,240) size 0x0
11   -layer at (8,42) size 320x240
12   - RenderVideo {VIDEO} at (0,0) size 320x240
13   -layer at (8,42) size 320x240
14   - RenderBlock (relative positioned) {DIV} at (0,0) size 320x240
15   -layer at (8,257) size 320x25
16   - RenderDeprecatedFlexibleBox (positioned) {DIV} at (0,215) size 320x25
17   - RenderButton {INPUT} at (6,3) size 18x18
18   - RenderButton {INPUT} at (32,4) size 16x16
19   - RenderDeprecatedFlexibleBox {DIV} at (49,5) size 216x15
20   - RenderSlider {INPUT} at (45,2) size 126x13
21   - RenderDeprecatedFlexibleBox {DIV} at (0,0) size 126x13
22   - RenderBlock {DIV} at (0,2) size 116x8
23   - RenderBlock {DIV} at (116,2) size 10x8
24   - RenderButton {INPUT} at (297,4) size 16x16
25   - RenderButton {INPUT} at (267,6) size 14x12
26   -layer at (57,264) size 45x11
27   - RenderDeprecatedFlexibleBox {DIV} at (0,2) size 45x11 [color=#FFFFFF]
28   - RenderBlock (anonymous) at (9,0) size 26x11
29   - RenderText {#text} at (0,0) size 26x11
30   - text run at (0,0) width 26: "00:00"
31   -layer at (228,264) size 45x11
32   - RenderDeprecatedFlexibleBox {DIV} at (171,2) size 45x11 [color=#FFFFFF]
33   - RenderBlock (anonymous) at (7,0) size 31x11
34   - RenderText {#text} at (0,0) size 31x11
35   - text run at (0,0) width 31: "-00:06"
36   -layer at (102,266) size 10x8
37   - RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
1  LayoutTests/platform/mac/Skipped
@@ -611,7 +611,6 @@ canvas/philip/tests/2d.path.arc.scale.1.html
611 611
612 612 # Media tests that time out unexpectedly
613 613 # https://bugs.webkit.org/show_bug.cgi?id=81604
614   -http/tests/media/video-buffering-repaints-controls.html
615 614 http/tests/media/video-useragent.html
616 615 media/audio-garbage-collect.html
617 616
3  LayoutTests/platform/mac/test_expectations.txt
@@ -149,9 +149,6 @@ BUGWK74888 : fast/dom/HTMLTableElement/createCaption.html = TEXT
149 149 BUGWK74888 : fast/repaint/table-section-repaint.html = TEXT
150 150 BUGWK74888 : fast/table/frame-and-rules.html = TEXT
151 151
152   -// New test, needs image results added.
153   -BUGWK75570 : http/tests/media/video-buffering-repaints-controls.html = IMAGE
154   -
155 152 // Rebaseline required after bug 74874
156 153 BUGWK74874 : fast/table/027.html = TEXT
157 154 BUGWK74874 : fast/table/027-vertical.html = TEXT
10 ManualTests/media-controls.html
@@ -192,6 +192,16 @@
192 192 title: 'Audio with no source',
193 193 description: 'Should have "Rewind" and "Play" buttons. Should not blink/twitch if reloaded.',
194 194 html: '<audio controls></audio>'
  195 +},
  196 +'controls-buffer-update': {
  197 + title: 'Buffer progress bar updates',
  198 + description: '<p>The buffer progress bar should continue to update prior to video playback.</p>' +
  199 + '<p>Verify the progress bar representing the amount of video buffered continues to ' +
  200 + 'update prior to video playback. Keep the mouse pointer off the progress bar during this check ' +
  201 + 'as movement over the control will trigger a repaint which invalidates the test.</p><p>' +
  202 + 'It\'s expected that the video may stop buffering before the entire video is loaded.</p>',
  203 + html: '<video controls src="http://movies.apple.com/movies/us/apple/ipoditunes/2007/touch/ads/apple_ipodtouch_touch_640x360.mov' +
  204 + '?prevent_caching=' + new Date().getTime() + '"></video>'
195 205 }
196 206
197 207 };

0 comments on commit 4f71c92

Please sign in to comment.
Something went wrong with that request. Please try again.