Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Adjust flakiness dashboard gpu_tests image diff URLs.

https://bugs.webkit.org/show_bug.cgi?id=85423

Patch by Dave Tu <dtu@chromium.org> on 2012-05-07
Reviewed by Ojan Vafai.

* Tools/TestResultServer/static-dashboards/flakiness_dashboard.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information...
commit ba079da89fee9e39c37fb21c88de7f9079c9d704 1 parent 9ae760e
commit-queue@webkit.org authored
View
9 ChangeLog
@@ -1,3 +1,12 @@
+2012-05-07 Dave Tu <dtu@chromium.org>
+
+ Adjust flakiness dashboard gpu_tests image diff URLs.
+ https://bugs.webkit.org/show_bug.cgi?id=85423
+
+ Reviewed by Ojan Vafai.
+
+ * Tools/TestResultServer/static-dashboards/flakiness_dashboard.js:
+
2012-05-07 Liam Quinn <lquinn@rim.com>
[BlackBerry] WWW-Authenticate header on 200 response pops up authentication dialog
View
16 Tools/TestResultServer/static-dashboards/flakiness_dashboard.js
@@ -36,6 +36,7 @@ var GTEST_MODIFIERS = ['FLAKY', 'FAILS', 'MAYBE', 'DISABLED'];
var TEST_URL_BASE_PATH_TRAC = 'http://trac.webkit.org/browser/trunk/LayoutTests/';
var TEST_URL_BASE_PATH = "http://svn.webkit.org/repository/webkit/trunk/LayoutTests/";
var TEST_RESULTS_BASE_PATH = 'http://build.chromium.org/f/chromium/layout_test_results/';
+var GPU_RESULTS_BASE_PATH = 'http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/runs/'
// FIXME: These platform names should probably be changed to match the directories in LayoutTests/platform
// instead of matching the values we use in the test_expectations.txt file.
@@ -1863,6 +1864,11 @@ function loadExpectations(expectationsContainer)
}
}
+function gpuResultsPath(chromeRevision, builder)
+{
+ return chromeRevision + '_' + builder.replace(/[^A-Za-z0-9]+/g, '_');
+}
+
function loadGPUResultsForBuilder(builder, test, expectationsContainer)
{
var container = document.createElement('div');
@@ -1870,21 +1876,19 @@ function loadGPUResultsForBuilder(builder, test, expectationsContainer)
container.innerHTML = '<div><b>' + builder + '</b></div>';
expectationsContainer.appendChild(container);
- var baseUrl = 'http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/runs/'
var failureIndex = indexesForFailures(builder, test)[0];
var buildNumber = g_resultsByBuilder[builder].buildNumbers[failureIndex];
var pathToLog = builderMaster(builder).logPath(builder, buildNumber) + pathToFailureLog(test);
var chromeRevision = g_resultsByBuilder[builder].chromeRevision[failureIndex];
- var builderName = builder.replace(/[^A-Za-z0-9 ]/g, '').replace(/ /g, '_');
- var resultsUrl = baseUrl + chromeRevision + '_' + builderName + '_/';
+ var resultsUrl = GPU_RESULTS_BASE_PATH + gpuResultsPath(chromeRevision, builder);
var filename = test.split(/\./)[1] + '.png';
appendNonWebKitResults(container, pathToLog, 'non-webkit-results');
- appendNonWebKitResults(container, resultsUrl + 'gen/' + filename, 'gpu-test-results', 'Generated');
- appendNonWebKitResults(container, resultsUrl + 'ref/' + filename, 'gpu-test-results', 'Reference');
- appendNonWebKitResults(container, resultsUrl + 'diff/' + filename, 'gpu-test-results', 'Diff');
+ appendNonWebKitResults(container, resultsUrl + '/gen/' + filename, 'gpu-test-results', 'Generated');
+ appendNonWebKitResults(container, resultsUrl + '/ref/' + filename, 'gpu-test-results', 'Reference');
+ appendNonWebKitResults(container, resultsUrl + '/diff/' + filename, 'gpu-test-results', 'Diff');
}
function loadNonWebKitResultsForBuilder(builder, test, expectationsContainer)
View
6 Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js
@@ -673,3 +673,9 @@ test('popup', 2, function() {
hidePopup();
ok(!document.querySelector('#popup'));
});
+
+test('gpuResultsPath', 3, function() {
+ equal(gpuResultsPath('777777', 'Win7 Release (ATI)'), '777777_Win7_Release_ATI_');
+ equal(gpuResultsPath('123', 'GPU Linux (dbg)(NVIDIA)'), '123_GPU_Linux_dbg_NVIDIA_');
+ equal(gpuResultsPath('12345', 'GPU Mac'), '12345_GPU_Mac');
+});
Please sign in to comment.
Something went wrong with that request. Please try again.