New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New user with roles based on "reference user" #30

Closed
niv0 opened this Issue Apr 12, 2016 · 8 comments

Comments

Projects
None yet
2 participants
@niv0
Copy link

niv0 commented Apr 12, 2016

Would be great if new user can be created with same "role profile" as an existing "reference user".

@danhaywood

This comment has been minimized.

Copy link
Contributor

danhaywood commented May 27, 2016

Would "clone user" work as an approach?

@niv0

This comment has been minimized.

Copy link
Author

niv0 commented May 27, 2016

Yes, I think it would lead to same result.

@danhaywood

This comment has been minimized.

Copy link
Contributor

danhaywood commented May 27, 2016

Would you be happy to implement this, then (with tests)? Seems like quite a straight-forward enhancement.

@niv0

This comment has been minimized.

Copy link
Author

niv0 commented May 27, 2016

Ok , I can try that! Will send you a pull request when finished.

@danhaywood

This comment has been minimized.

Copy link
Contributor

danhaywood commented May 27, 2016

Good stuff, look forward to it.

I care more about a nice integration test than unit tests, you could add to https://github.com/isisaddons/isis-module-security/blob/master/integtests/src/test/java/org/isisaddons/module/security/integtests/user/ApplicationUserIntegTest.java (I used nested static classes as a way of organizing the testing of the responsibilities).

Cheers

@niv0

This comment has been minimized.

Copy link
Author

niv0 commented May 27, 2016

Yes I saw that, I will introduce new nested static class as test.

niv0 pushed a commit to niv0/isis-module-security that referenced this issue May 27, 2016

@niv0

This comment has been minimized.

Copy link
Author

niv0 commented May 27, 2016

Hi Dan, I created a pull request

#33

Regs,Vladimir

niv0 pushed a commit to niv0/isis-module-security that referenced this issue May 31, 2016

danhaywood added a commit that referenced this issue Dec 5, 2016

Merge pull request #33 from niv0/master
#30 New user with roles based on "reference user"
@danhaywood

This comment has been minimized.

Copy link
Contributor

danhaywood commented Dec 5, 2016

was closed by PR #33

@danhaywood danhaywood closed this Dec 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment