Skip to content

Replace colon with dash in timestamp variables - #620

Merged
ssheorey merged 6 commits into
isl-org:devfrom
Cassius0924:replace_colon
Oct 23, 2023
Merged

ssheorey merged 6 commits into
isl-org:devfrom
Cassius0924:replace_colon

Conversation

@Cassius0924

@Cassius0924 Cassius0924 commented Oct 19, 2023 •

Copy link
Copy Markdown
Contributor

When running the Semantic Segmentation program on exFAT SSD, Python cannot create log files with colon in the filename timestamp. This causes OSError.

test 0/1: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 79845/79845 [00:06<00:00, 13174.09it/s]
/root/.virtualenvs/ETRS/lib/python3.8/site-packages/open3d/_ml3d/torch/modules/metrics/semseg_metric.py:54: RuntimeWarning: Mean of empty slice
  accs.append(np.nanmean(accs))
/root/.virtualenvs/ETRS/lib/python3.8/site-packages/open3d/_ml3d/torch/modules/metrics/semseg_metric.py:87: RuntimeWarning: Mean of empty slice
  ious.append(np.nanmean(ious))
Traceback (most recent call last):
  File "SemanticSegmentation.py", line 43, in <module>
    pipeline.run_test()
  File "/root/.virtualenvs/ETRS/lib/python3.8/site-packages/open3d/_ml3d/torch/pipelines/semantic_segmentation.py", line 198, in run_test
    log.addHandler(logging.FileHandler(log_file_path))
  File "/usr/lib/python3.8/logging/__init__.py", line 1147, in __init__
    StreamHandler.__init__(self, self._open())
  File "/usr/lib/python3.8/logging/__init__.py", line 1176, in _open
    return open(self.baseFilename, self.mode, encoding=self.encoding)
OSError: [Errno 22] Invalid argument: '/home/ncistwlwsys/hezhizhou-projects/disk/SingleAzureKinect3DReconstruction/src/python/logs/RandLANet_SemanticKITTI_torch/log_test_2023-10-19_20:57:44.txt'

Verified that with this fix, the Semantic Segmentation program can now successfully create log files on exFAT SSD.


This change is Reviewable

mariusud and others added 5 commits February 20, 2023 08:17
* update update_probs to only update the probabilities, as the name implies

* update semantic segmentation to update labels based on probabilities at the end of an update

* Docstring for Returns updated

* styling

* build gui module

---------

Co-authored-by: Benjamin Ummenhofer <benjaminum@gmail.com>
# Conflicts:
#	ci/run_ci.sh

@ssheorey ssheorey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Cassius0924 !

@ssheorey
ssheorey changed the base branch from master to dev October 23, 2023 17:02
@ssheorey
ssheorey merged commit c62c4f5 into isl-org:dev Oct 23, 2023
Cassius0924 added a commit to Cassius0924/Open3D-ML that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants