Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django 4 support #49

Closed
wants to merge 10 commits into from
Closed

django 4 support #49

wants to merge 10 commits into from

Conversation

cunla
Copy link

@cunla cunla commented Dec 21, 2021

ugettext_lazy => gettext_lazy
django.conf.urls.url => django.url.re_path
As described here

@eskhool
Copy link

eskhool commented Mar 22, 2022

@cunla I reviewed your commits. Some of the refactoring is definitely on point and so is your project standards. However I would prefer that we maintain a single code base for multiple Django versions and I think it can be managed. Do let me know if re-merging the code makes sense for you? Our tech team will have (allotted) bandwidth to keep looking into this regularly so can support on a more than volunteer basis. Cheers

@cunla
Copy link
Author

cunla commented Mar 22, 2022

Hi @eskhool, thanks for getting in touch.

I would like to be the maintainer for this package and created a request in pypi to claim the package name.
We are a group of professional python developers who will maintain it - you are naturally welcome to use the package and merge the code to yours, or alternatively participate in maintaining the new repository (open issues, create PRs, etc.).

@eskhool
Copy link

eskhool commented Mar 23, 2022

Hi @cunla, it looks by the name of your repo that you intend to keep it for Django 4 onwards only? If thats the case, then I guess we will probably cherry pick and adapt merge your changes if we can to keep this package working with Django 3.2

@tom-price
Copy link
Collaborator

@eskhool, I do agree with your stance on having the project support the Django 3.2 LTS release. I don't have project owner access to PyPi myself and am unsure what to do. We're using my own fork at our company and the fragmentation of this project is obviously concerning to me.

@cunla
Copy link
Author

cunla commented Mar 23, 2022

I'll add django 3.2 support today

@tom-price
Copy link
Collaborator

I'll add django 3.2 support today

Great, this evening (currently on vacation) I'll have a look through the updates you've made on your fork and see if I've got any comments / input.

@cunla
Copy link
Author

cunla commented Mar 23, 2022

Find here PR for django3.2 support.
Version published on pypi: https://pypi.org/project/django-rqscheduler4/
Currently the name is still django-rqscheduler4. I have claimed the django-rq-scheduler name on pypi and hopefully soon they will approve it.

@cunla cunla closed this Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants