-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bye bye Foundation & Browserify, hello Webpack & PostCSS #77
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
dc4ed39
removed sass; added webpack and postcss
thomasdegry dce394a
Add postcss-css to deps
thomasdegry c2d5535
removed watchify
thomasdegry 8984424
Remove cookiecutter question on generation
thomasdegry 7d487a6
Fixed some gulp issues
thomasdegry a18809e
removed default open because it drives me INSANE
thomasdegry 9866025
Fix npm run lint to lint css instead of scss
thomasdegry db863af
Updated dependencies
thomasdegry 237ecc6
Updated to es2017 and explicitely use it in webpack config
thomasdegry 7d1e263
Fixed some missing deps
thomasdegry b6bc623
Remove rest plugin since it's built into es2017
thomasdegry e26c42c
Trying to add suitcss
thomasdegry 06d5d25
Add suitcss dep
thomasdegry e159b5f
remove all references to use_foundation_sites
akrawchyk a3bdb4b
gulp-suitcss
akrawchyk f809f71
Merge pull request #78 from istrategylabs/ak-fix
akrawchyk f1b20c9
Continue suitcss setup and linting config
thomasdegry 34f2b12
Added basic circle.yml file for linting
thomasdegry d44dc2e
Dev install on circle
thomasdegry 314c9a7
fix path to css file
akrawchyk 2eeb568
prefer standard to eslint, remove unused config, upgrade packages, ad…
akrawchyk a0ddfc3
lock version of postcss-import to 8.0.2
akrawchyk 7ff0713
more strict version of node and npm
akrawchyk 7c50263
Added more css boilerplate
thomasdegry 2f05437
add error logging to critical output, remove redundant role attr
akrawchyk 4210cff
code instead of span tags
thomasdegry 3701a4a
Fixed some stylelint issues
thomasdegry 2b89fd0
Readme updates
thomasdegry 855652a
Added raw tags to grid.html
thomasdegry b10496d
Added convict to the nunjucks and js
thomasdegry 47c8e9f
Updated readme with convict info
thomasdegry 8e5e840
Little mistake in convict readme section
thomasdegry 70d2375
Removed one more nconf reference
thomasdegry e4b4b15
Added some more css boiler plate and variables
thomasdegry 3f1c539
Yarn in circle.yml file
thomasdegry 7c8ace9
Made code 0.9rem instead of 9rem lol
thomasdegry 4e57981
Added buildpack urls to readme for convenience
thomasdegry 9e4368b
Fix circleci
thomasdegry a179db2
Nesting was broken
thomasdegry 6c5d001
Updated cookiecutter readme
thomasdegry a0a06a9
Uglify by default and generate sourcemaps
thomasdegry a9c6912
Spelling error in readme fix
thomasdegry 7185eb4
Hex codes
thomasdegry f167e81
Added new line to readme
thomasdegry 309acd6
Another red -> hex red
thomasdegry cfd1321
Readme update re. convict and heroku
thomasdegry 7178d4f
fix cookiecutter var
akrawchyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
{ | ||
"presets": ["es2015"], | ||
"plugins": ["syntax-trailing-function-commas"]{% if cookiecutter.use_foundation_sites == 'y' -%}, | ||
"ignore": "jquery" | ||
{%- endif %} | ||
"presets": ["es2015"] | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
6 | ||
6.10 |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
machine: | ||
node: | ||
version: 6 | ||
environment: | ||
NODE_ENV: production | ||
dependencies: | ||
override: | ||
- npm install --dev | ||
test: | ||
override: | ||
- npm run lint |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,24 @@ | ||
import nconf from 'nconf' | ||
var convict = require('convict'); | ||
|
||
nconf.env().argv() | ||
|
||
nconf.defaults({ | ||
var config = convict({ | ||
env: { | ||
doc: 'The applicaton environment.', | ||
format: ['production', 'development', 'test'], | ||
default: 'development', | ||
env: 'NODE_ENV' | ||
}, | ||
secretMessage: { | ||
doc: 'Some test secret message.', | ||
format: String, | ||
default: 'WHAZZAAAAHHHHH' | ||
} | ||
}) | ||
|
||
export default nconf | ||
// Load environment dependent configuration if desired | ||
// var env = config.get('env'); | ||
// config.loadFile('./config/' + env + '.json'); | ||
|
||
// Perform validation | ||
config.validate({allowed: 'strict'}); | ||
|
||
module.exports = config; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasdegry can we use
yarn
here instead? https://circleci.com/docs/1.0/yarn/Also, can you try integrating an example application with circle before we merge this?