lego1: Add MxCriticalSection implementation#11
Merged
itsmattkc merged 3 commits intoisledecomp:masterfrom Jun 12, 2023
Merged
Conversation
Contributor
|
Excellent, looks good to me. Thanks! |
madebr
pushed a commit
to madebr/isle
that referenced
this pull request
Jun 25, 2024
* Rename LegoEdge::GetOpposingPoint to LegoEdge::CWVertex (isledecomp#977) * Fix Radio::HandleControl COMPAT_MODE branch (isledecomp#978) --------- Co-authored-by: DmitriLeon2000 <dmitryaveron2000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the implementation for
MxCriticalSection. The assembly output matches the original (manually verified).In addition to the existing declarations, I've added two member functions (called them
EnterandLeave) that seem to fulfill the functionality of locking/entering the mutex/CS.It's been over 10 years since I've done any reversing/decompilation so I'm a little rusty and picked something easy to start with. It's great to see how far the tooling has come though! Please let me know if something needs changing/fixing.