Implement MxDisplaySurface::VTable0x28#391
Merged
foxtacles merged 17 commits intoDec 31, 2023
Merged
Conversation
Member
Author
|
Match is at 70%+ now - merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the implementation for
VTable0x28, which was the last piece necessary to render something from the initial Smacker video innocd.si.The match isn't great at ~30% and it will probably take a lot of further experimentation to get it right, since it's a very large function again and minor differences in variable placement/usage, inline functions etc. are highly important. Functionally I believe it should be accurate, although it's easy to miss something with a function of this size, so I'm inviting everyone to check it out and look for any issues. The 16-bit branches are the one currently most relevant.
Many variable names are also still placeholders or should be improved - suggestions welcome.
LEGO.2023-12-30.23-46-49.mp4